Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PrivacyPro terms of service link #2907

Merged
merged 1 commit into from
May 30, 2024

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/414709148257752/1207361720787330/f
Tech Design URL:
CC:

Description:

Add link to Privacy Pro Terms of Service

Steps to test this PR:

Open settings, validate if link is present.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@bwaresiak bwaresiak changed the base branch from main to release/7.122.0 May 30, 2024 09:52
@bwaresiak bwaresiak force-pushed the bartek/pp-terms-of-service-link branch from 096f03f to 4ae222a Compare May 30, 2024 09:53
@diegoreymendez diegoreymendez self-requested a review May 30, 2024 10:07
@Bunn Bunn merged commit 313908d into release/7.122.0 May 30, 2024
18 checks passed
@Bunn Bunn deleted the bartek/pp-terms-of-service-link branch May 30, 2024 10:32
samsymons added a commit that referenced this pull request May 31, 2024
* main:
  Update VPN support copy (#2894)
  Settings experiment disabled and new Settings rolled out to all users (#2904)
  Release 7.122.0-2 (#2909)
  PrivacyPro terms of service link (#2907)
  Release 7.122.0-1 (#2906)
  Fix release branch VPN auth issues (#2903)
  Disable the autofill survey (#2899)
  fire RMF message updated notification if we make any change to the store (#2891)
  Fix maestro config so it runs (#2896)
  Disable the autofill survey (#2899)
  Release 7.122.0-0 (#2898)
  Do not refresh collection view when we are changing the display mode (#2895)
  Add option to crash the app with exception from debug menu (#2897)
  Remove default.profraw (#2893)
  Guard swipe tabs scroll state (#2888)
samsymons added a commit that referenced this pull request Jun 1, 2024
# By bwaresiak (6) and others
# Via Bartek Waresiak (1) and others
* main: (30 commits)
  Update VPN support copy (#2894)
  Settings experiment disabled and new Settings rolled out to all users (#2904)
  Release 7.122.0-2 (#2909)
  PrivacyPro terms of service link (#2907)
  Release 7.122.0-1 (#2906)
  Fix release branch VPN auth issues (#2903)
  Disable the autofill survey (#2899)
  fire RMF message updated notification if we make any change to the store (#2891)
  Fix maestro config so it runs (#2896)
  Disable the autofill survey (#2899)
  Release 7.122.0-0 (#2898)
  Do not refresh collection view when we are changing the display mode (#2895)
  Add option to crash the app with exception from debug menu (#2897)
  Remove default.profraw (#2893)
  Guard swipe tabs scroll state (#2888)
  Add debug pixels for data cleanup (#2890)
  Bump rexml from 3.2.6 to 3.2.8 (#2866)
  Remove VPN waitlist code (#2795)
  Privacy Pro Follow ups (#2882)
  Clean up subscriptionFeature on init (#2880)
  ...

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants