Add controller VPN uninstall pixels #2857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 15, 2024
samsymons
approved these changes
May 15, 2024
diegoreymendez
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 16, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207324076451291/f iOS PR: duckduckgo/iOS#2857 macOS PR: duckduckgo/macos-browser#2781 What kind of version bump will this require?: Minor ## Description Integrating the latest macOS changes in BSK. Nothing should change for iOS except for a crash being fixed.
diegoreymendez
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
May 16, 2024
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207324076451291/f iOS PR: duckduckgo/iOS#2857 BSK PR: duckduckgo/BrowserServicesKit#822 ## Description Adds VPN uninstall pixels to the controller.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206580121312550/1207324076451291/f
macOS PR: duckduckgo/macos-browser#2781
BSK PR: duckduckgo/BrowserServicesKit#822
Description
Integrating the latest macOS changes in BSK. Nothing should change for iOS except for a crash being fixed.
Testing
Ensure the CI is green and make sure the VPN starts and stops normally.
Internal references:
Software Engineering Expectations
Technical Design Template