Add bookmarks to top hits suggestions on iOS #2835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bot: not in app board
tomasstrba
approved these changes
May 9, 2024
brindy
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
May 9, 2024
Required: Task/Issue URL: https://app.asana.com/0/0/1207251449708624/f iOS PR: duckduckgo/iOS#2835 macOS PR: duckduckgo/macos-browser#2754 What kind of version bump will this require?: Major/Minor/Patch Optional: Tech Design URL: CC: Description: Bookmarks are added to top hits on iOS, but the behaviour is unchanged on macOS. Steps to test this PR: iOS On iOS launch the app (use the md variant by editing the scheme > run > check environment variable VARIANT is md and enabled Add some bookmarks Start typing in the address bar The bookmarks should appear in the top hits section (ie at the top of the suggestions list) Check that launching the app clean with no variant still works as expected. macOS Launch the app and confirm that suggestions works as it did previously. ie Bookmarks should not be in top hits unless they have been visited several times.
|
Thanks @tomasstrba - that's all being updated in my current project anyway. |
samsymons
added a commit
that referenced
this pull request
May 9, 2024
* main: Upload logs on cancel (#2836) Add bookmarks to top hits suggestions on iOS (#2835) Fix Maestro reporting for e2e tests (#2713) support marketplace kit (#2833) Enable attribution flag (#2825) Release 7.119.0-0 (#2831) Fix subscriptions glitch in Settings (#2828) Delegate SecureVault KeyStore Events in All Scenarios (#2827) Clears subscription cache on restore (#2823)
samsymons
added a commit
that referenced
this pull request
May 10, 2024
# By amddg44 (3) and others # Via GitHub (1) and amddg44 (1) * main: Enable gzip compression for Sync PATCH payloads (#2805) sync error notify (#2822) Wire up VPN error UI (#2826) Mergeback from release/7.119.0 Release 7.119.0-1 (#2840) Add temporary survey to Passwords screen (#2834) Upload logs on cancel (#2836) Add bookmarks to top hits suggestions on iOS (#2835) Fix Maestro reporting for e2e tests (#2713) support marketplace kit (#2833) Enable attribution flag (#2825) Release 7.119.0-0 (#2831) Fix subscriptions glitch in Settings (#2828) Delegate SecureVault KeyStore Events in All Scenarios (#2827) Clears subscription cache on restore (#2823) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
May 13, 2024
* main: (27 commits) Release 7.120.0-0 (#2846) Enable gzip compression for Sync PATCH payloads (#2805) sync error notify (#2822) Wire up VPN error UI (#2826) Mergeback from release/7.119.0 Release 7.119.0-1 (#2840) Add temporary survey to Passwords screen (#2834) Upload logs on cancel (#2836) Add bookmarks to top hits suggestions on iOS (#2835) Fix Maestro reporting for e2e tests (#2713) support marketplace kit (#2833) Enable attribution flag (#2825) Release 7.119.0-0 (#2831) Fix subscriptions glitch in Settings (#2828) Delegate SecureVault KeyStore Events in All Scenarios (#2827) Clears subscription cache on restore (#2823) Enable field validation for Sync payloads (#2807) Fix up address bar spoofing tests to match new behaviours. (#2743) Release 7.118.0-4 (#2821) Settings: onAppear changed to onDisappear (#2817) (#2820) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1207251449708624/f
Tech Design URL:
CC:
Description:
Adds bookmarks to top hits for iOS.
Steps to test this PR:
See duckduckgo/BrowserServicesKit#812