lastDisconnectError now matches against NEVPNConnectionError #2753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graeme
approved these changes
Apr 22, 2024
samsymons
added a commit
that referenced
this pull request
Apr 26, 2024
…utdown # By Christopher Brind (4) and others # Via Chris Brind (1) and others * main: (21 commits) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) iOS: Bundle-Specfic Autofill Secure Vault Keychain Items (#2759) Fix dSYM archive upload to S3 (#2778) Fix dSYM archive upload to S3 (#2778) Release 7.117.0-0 (#2776) Select Subscription Environment in Debug Settings (#2766) lastDisconnectError now matches against NEVPNConnectionError (#2753) Release 7.116.0-3 (#2774) ... # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1203137811378537/1207090443037558/f
Tech Design URL:
CC:
Description:
From https://developer.apple.com/documentation/networkextension/nevpnconnectionerrordomain:
NEVPNConnectionErrorDomain: Match this constant to the domain of an NSError encountered when calling methods on NEVPNConnection. The NEDNSSettingsManagerError enumeration defines possible code values for these errors.
which doesn't quite make sense. I feel like it should be matched against https://developer.apple.com/documentation/networkextension/nevpnconnectionerror instead.
Steps to test this PR:
1.
2.
Copy Testing:
’rather than'Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template