Subscriptions: Fix back navigation button on user.cancel

DuckDuckGo/Subscription/UserScripts/SubscriptionPagesUseSubscriptionFeature.swift

@@ -227,7 +227,7 @@ final class SubscriptionPagesUseSubscriptionFeature: Subfeature, ObservableObjec
             purchaseTransactionJWS = transactionJWS
 
         case .failure(let error):
-
+            setTransactionStatus(.idle)
             switch error {
             case .cancelledByUser:
                 setTransactionError(.cancelledByUser)
@@ -241,7 +241,6 @@ final class SubscriptionPagesUseSubscriptionFeature: Subfeature, ObservableObjec
                 setTransactionError(.purchaseFailed)
             }
             originalMessage = original
-            setTransactionStatus(.idle)
             return nil
         }
 

DuckDuckGo/Subscription/ViewModel/SubscriptionFlowViewModel.swift

@@ -56,9 +56,10 @@
         var shouldActivateSubscription = false
         var canNavigateBack: Bool = false
         var transactionError: SubscriptionPurchaseError?
-        var shouldHideBackButton = false
         var selectedFeature: SelectedFeature = .none
         var viewTitle: String = UserText.subscriptionTitle
+        var shouldDismissView: Bool = false
+        var backButtonTitle: String = UserText.settingsTitle
     }
 
     // Read only View State - Should only be modified from the VM
@@ -139,7 +140,7 @@
 
     // swiftlint:disable cyclomatic_complexity
     @MainActor
     private func handleTransactionError(error: SubscriptionPagesUseSubscriptionFeature.UseSubscriptionError) {
 
         var isStoreError = false
         var isBackendError = false
@@ -198,6 +199,11 @@
             // The observer of `transactionError` does the same calculation, if the error is anything else than .hasActiveSubscription then shows a "Something went wrong" alert
             DailyPixel.fireDailyAndCount(pixel: .privacyProPurchaseFailure)
         }
+
+        // Reset Back Button
+        backButtonEnabled(true)
+        updateBackButtonTitle(forURL: self.webViewModel.url)
+        clearTransactionError()
     }
     // swiftlint:enable cyclomatic_complexity
 
@@ -223,6 +229,7 @@
                 if strongSelf.backButtonForURL(currentURL: currentURL) {
                     DispatchQueue.main.async {
                         strongSelf.state.canNavigateBack = value
+                        strongSelf.updateBackButtonTitle(forURL: currentURL)
                     }
                 }
             }
@@ -246,11 +253,16 @@
     }
 
     private func backButtonForURL(currentURL: URL) -> Bool {
-        return currentURL.forComparison() != URL.subscriptionBaseURL.forComparison() &&
-        currentURL.forComparison() != URL.subscriptionActivateSuccess.forComparison() &&
+        return currentURL.forComparison() != URL.subscriptionActivateSuccess.forComparison() &&
         currentURL.forComparison() != URL.subscriptionPurchase.forComparison()
     }
 
+    private func updateBackButtonTitle(forURL url: URL?) {
+        guard let url else { return }
+        state.backButtonTitle = url.forComparison() == URL.subscriptionBaseURL.forComparison() ? UserText.settingsTitle : UserText.backButtonTitle
+
+    }
+
     private func cleanUp() {
         transactionStatusTimer?.invalidate()
         canGoBackCancellable?.cancel()
@@ -275,6 +287,11 @@
     private func setTransactionStatus(_ status: SubscriptionTransactionStatus) {
         self.state.transactionStatus = status
 
+        // Hide Back button when processing a transaction
+        if status != .idle {
+            self.backButtonEnabled(false)
+        }
+
         // Fire a temp pixel if status is not back to idle in 60s
         // Remove block when removing pixel
         // https://app.asana.com/0/1204099484721401/1207003487111848/f
@@ -337,7 +354,12 @@
 
     @MainActor
     func navigateBack() async {
-        await webViewModel.navigationCoordinator.goBack()
+        if webViewModel.url?.forComparison() != URL.subscriptionBaseURL.forComparison() &&
+            webViewModel.canGoBack {
+            await webViewModel.navigationCoordinator.goBack()
+        } else {
+            state.shouldDismissView = true
+        }
     }
 
     @MainActor

DuckDuckGo/Subscription/Views/SubscriptionFlowView.swift

@@ -80,7 +80,7 @@ struct SubscriptionFlowView: View {
                 }
             }
             .navigationBarTitleDisplayMode(.inline)
-            .navigationBarBackButtonHidden(viewModel.state.canNavigateBack || viewModel.subFeature.transactionStatus != .idle)
+            .navigationBarBackButtonHidden(true)
             .interactiveDismissDisabled(viewModel.subFeature.transactionStatus != .idle)
             .edgesIgnoringSafeArea(.bottom)
             .tint(Color(designSystemColor: .textPrimary))
@@ -94,7 +94,7 @@ struct SubscriptionFlowView: View {
             }, label: {
                 HStack(spacing: 0) {
                     Image(systemName: Constants.backButtonImage)
-                    Text(UserText.backButtonTitle)
+                    Text(viewModel.state.backButtonTitle)
                 }
 
             })
@@ -167,6 +167,10 @@ struct SubscriptionFlowView: View {
             }
         }
 
+        .onChange(of: viewModel.state.shouldDismissView) { _ in
+            dismiss()
+        }
+
         .onFirstAppear {
             setUpAppearances()
             Task { await viewModel.onFirstAppear() }