Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use custom back button for Purchase Flow #2731

Closed
wants to merge 1 commit into from
Closed

Use custom back button for Purchase Flow #2731

wants to merge 1 commit into from

Conversation

afterxleep
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/414709148257752/1207054736335272/f

Description:

  • Fixes issue causing the 'Back' button to not re-appear if the user cancels the subscription purchase mid-transaction.

This removes the native navigation button and uses a custom navBar item to handle both webview navigation and dismissal.

Steps to test this PR:

  1. Go to Settings Get Privacy Pro
  2. Select a plan
  3. Hit Subscribe
  4. Cancel the transaction on the Apple dialog
  5. Observe the "Settings" button is visible in the top-left
  6. Tap the button to go back to Settings

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@afterxleep afterxleep closed this Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@afterxleep