Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subscription State improvements + Remove SUBSCRIPTION Flag #2726

Merged
merged 12 commits into from
Apr 15, 2024

Conversation

afterxleep
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204099484721401/1207054244226883/f

Description:

  • Optimize the state management for Subscription Settings ViewModel
  • Remove SUBSCRIPTION compiler flag

Steps to test this PR:

  1. Smoke test subscriptions

@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 12, 2024
Copy link

github-actions bot commented Apr 12, 2024

Warnings
⚠️ PR has more than 500 lines of code changing. Consider splitting into smaller PRs if possible.

Generated by 🚫 dangerJS against 8877bf0

@afterxleep afterxleep requested a review from miasma13 April 12, 2024 10:33
@afterxleep afterxleep removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 12, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 12, 2024
@miasma13
Copy link
Contributor

Seems like not all instances were removed. Please doublecheck with find . | xargs grep -sw 'SUBSCRIPTION'

@afterxleep afterxleep removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Apr 12, 2024
@afterxleep afterxleep merged commit e4a3363 into main Apr 15, 2024
13 checks passed
@afterxleep afterxleep deleted the daniel/subscriptions/state.updates branch April 15, 2024 09:48
samsymons added a commit that referenced this pull request Apr 18, 2024
* main:
  Release 7.116.0-1 (#2761)
  Remove validator app (#2754)
  Fix crash when quickly adding/removing tabs in switcher (#2760)
  Fix settings navigation bar colors after reopening (#2758)
  Alpha ad-hoc lane (#2492)
  Keep a weak reference to UserScriptMessageBroker (#2755)
  Add refresh config cell to top of debug (#2735)
  VPN: Replace available interfaces in VPN metadata (#2750)
  Require device auth to be set in order to use Sync (#2722)
  Add new iOS pixels for measuring navigation  (#2730)
  Privacy pro metadata updates (#2747)
  Update autoconsent to v10.6.1 (#2734)
  Limit Stale actions to issues (#2745)
  Change DAU pixel for VPN to weekly (#2684)
  Support Autofill Domains with Port Number Suffixes (#2715)
  Update secure vault error pixels to fire daily (#2557)
  Subscription: Fix 'Back' button not present (#2741)
  Subscription State improvements + Remove SUBSCRIPTION Flag (#2726)
  Release 7.116.0-0 (#2739)
  Release 7.116.0-0 (#2737)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants