Remove URLs from suggestion search terms #2683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
alessandroboron
commented
Apr 5, 2024
|
|
||
| return url | ||
| }) | ||
| loader = SuggestionLoader(dataSource: self, urlFactory: URL.makeURL(fromSuggestionPhrase:)) |
There was a problem hiding this comment.
I thought to align iOS with macOS. I moved the URLFactory function into BSK/Suggestions and have iOS & macOS use the function without duplicating the/having similar code.
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
|
This PR has been closed after 14 days of inactivity. Feel free to reopen it if you plan to continue working on it or have further discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206836396714144/f
Description:
Removes URLs suggestions from the search term when typing on the address bar.
Steps to test this PR:
Type “face”, “ama” or “ace" on the address bar.
Expected Result: The search term suggestions should not include “www.facebook.com”, “www.amazon.com”, “www.acer.com/“
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template