Don't crash on assert in alpha builds #2667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Going to merge this so that we can get it out in tonight's alpha and validate it. Thanks for this! |
afterxleep
added a commit
that referenced
this pull request
Apr 4, 2024
This reverts commit 760b58a.
afterxleep
added a commit
that referenced
this pull request
Apr 4, 2024
This reverts commit 2f3b4f1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206985884087562/f
Description:
As we saw in Crashes when opening from external links with auto-clear+expiry alpha builds can crash on asserts
Steps to test this PR:
Can only be tested after merge. Use https://app.asana.com/0/414709148257752/1206731143449260 as a test case that was previously crashing. But if you want to test the added config, you could.
OTHER_SWIFT_FLAGSline to beAlpha Debug.Copy Testing:
’rather than’Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
—
Internal references:
Software Engineering Expectations
Technical Design Template