Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix settings maestro text #2613

Merged
merged 3 commits into from
Mar 19, 2024
Merged

fix settings maestro text #2613

merged 3 commits into from
Mar 19, 2024

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Mar 19, 2024

Task/Issue URL: https://app.asana.com/0/414709148257752/1206861154682332/f
Tech Design URL:
CC:

Description:
Fixes the maestro text that fails to do with testing saving of DuckDuckGo settings

Steps to test this PR:

  1. Run the maestro tests locally
  2. Run the maestro test GHA using my branch https://github.com/duckduckgo/iOS/actions/workflows/end-to-end.yml

@brindy brindy requested a review from loremattei March 19, 2024 09:05
Copy link
Contributor

@loremattei loremattei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@loremattei loremattei merged commit 22690ad into main Mar 19, 2024
19 checks passed
@loremattei loremattei deleted the brindy/fix-maestro-test branch March 19, 2024 12:36
samsymons added a commit that referenced this pull request Mar 20, 2024
# By Anh Do (2) and others
# Via GitHub
* main:
  23. Subscriptions:  - Feature Flags (#2605)
  fix settings maestro text (#2613)
  Web pixels (handlers + pixels) (#2611)
  Handle subscription-related iOS use cases (#2597)
  Remove hardcoded NetP staging endpoint (#2612)
  Add Privacy Manifests to app extensions (#2608)
  Add a VPN metadata section to the debug UI (#2502)
  Use History in Suggestions on iOS (#2552)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Mar 21, 2024
# By Sam Symons (3) and others
# Via GitHub
* main:
  Entitlements cache fixes (#2620)
  BSK update for RMF app build version improvement (#2564)
  Surface the last-used password first in autofill prompt when filling passwords (#2600)
  VPN UI improvements part 1 - basic copy and UI changes (#2580)
  Add setting to display full URL address (#2587)
  Don't refresh swipe tabs model on background changes (#2610)
  23. Subscriptions:  - Feature Flags (#2605)
  fix settings maestro text (#2613)
  Web pixels (handlers + pixels) (#2611)
  Handle subscription-related iOS use cases (#2597)
  Remove hardcoded NetP staging endpoint (#2612)
  Add Privacy Manifests to app extensions (#2608)
  Add a VPN metadata section to the debug UI (#2502)
  Use History in Suggestions on iOS (#2552)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants