Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hardcoded NetP staging endpoint #2612

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/1203137811378537/1206872546589217/f
Tech Design URL:
CC:

Description:

Steps to test this PR:
1.
2.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@quanganhdo quanganhdo self-assigned this Mar 18, 2024
@github-actions github-actions bot added the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 18, 2024
@quanganhdo quanganhdo removed the bot: not in app board Added by automation for pull requests with tasks not added to iOS App Board Asana project label Mar 18, 2024
@quanganhdo quanganhdo marked this pull request as ready for review March 18, 2024 20:46
@quanganhdo quanganhdo merged commit 2deb813 into main Mar 18, 2024
13 checks passed
@quanganhdo quanganhdo deleted the anh/netp-no-hardcoded-endpoint branch March 18, 2024 21:02
samsymons added a commit that referenced this pull request Mar 20, 2024
# By Anh Do (2) and others
# Via GitHub
* main:
  23. Subscriptions:  - Feature Flags (#2605)
  fix settings maestro text (#2613)
  Web pixels (handlers + pixels) (#2611)
  Handle subscription-related iOS use cases (#2597)
  Remove hardcoded NetP staging endpoint (#2612)
  Add Privacy Manifests to app extensions (#2608)
  Add a VPN metadata section to the debug UI (#2502)
  Use History in Suggestions on iOS (#2552)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons added a commit that referenced this pull request Mar 21, 2024
# By Sam Symons (3) and others
# Via GitHub
* main:
  Entitlements cache fixes (#2620)
  BSK update for RMF app build version improvement (#2564)
  Surface the last-used password first in autofill prompt when filling passwords (#2600)
  VPN UI improvements part 1 - basic copy and UI changes (#2580)
  Add setting to display full URL address (#2587)
  Don't refresh swipe tabs model on background changes (#2610)
  23. Subscriptions:  - Feature Flags (#2605)
  fix settings maestro text (#2613)
  Web pixels (handlers + pixels) (#2611)
  Handle subscription-related iOS use cases (#2597)
  Remove hardcoded NetP staging endpoint (#2612)
  Add Privacy Manifests to app extensions (#2608)
  Add a VPN metadata section to the debug UI (#2502)
  Use History in Suggestions on iOS (#2552)

# Conflicts:
#	DuckDuckGo.xcodeproj/project.pbxproj
#	DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants