23. Subscriptions: - Feature Flags #2605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…l/subscriptions/20.caching # Conflicts: # DuckDuckGo/SettingsSubscriptionView.swift # DuckDuckGo/SettingsViewModel.swift
…ons/21.manage.other.purchases # Conflicts: # DuckDuckGo/Subscription/ViewModel/SubscriptionSettingsViewModel.swift
…criptions/23.FeatureFlags
afterxleep
removed
the
bot: not in app board
afterxleep
changed the title
…criptions/23.FeatureFlags
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
miasma13
requested review from
miasma13,
quanganhdo,
samsymons and
diegoreymendez
quanganhdo
reviewed
Mar 19, 2024
quanganhdo
approved these changes
Mar 19, 2024
samsymons
added a commit
that referenced
this pull request
Mar 20, 2024
# By Anh Do (2) and others # Via GitHub * main: 23. Subscriptions: - Feature Flags (#2605) fix settings maestro text (#2613) Web pixels (handlers + pixels) (#2611) Handle subscription-related iOS use cases (#2597) Remove hardcoded NetP staging endpoint (#2612) Add Privacy Manifests to app extensions (#2608) Add a VPN metadata section to the debug UI (#2502) Use History in Suggestions on iOS (#2552) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
samsymons
added a commit
that referenced
this pull request
Mar 21, 2024
# By Sam Symons (3) and others # Via GitHub * main: Entitlements cache fixes (#2620) BSK update for RMF app build version improvement (#2564) Surface the last-used password first in autofill prompt when filling passwords (#2600) VPN UI improvements part 1 - basic copy and UI changes (#2580) Add setting to display full URL address (#2587) Don't refresh swipe tabs model on background changes (#2610) 23. Subscriptions: - Feature Flags (#2605) fix settings maestro text (#2613) Web pixels (handlers + pixels) (#2611) Handle subscription-related iOS use cases (#2597) Remove hardcoded NetP staging endpoint (#2612) Add Privacy Manifests to app extensions (#2608) Add a VPN metadata section to the debug UI (#2502) Use History in Suggestions on iOS (#2552) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1206807550798011/f
Plan: https://app.asana.com/0/0/1206820386373649/f
BSK PR: https://github.com/duckduckgo/BrowserServicesKit/pull/717/files
Description:
How to test (Feature Availability):
How to test (Disallowing Purchases):
SubscriptionPagesUseSubscriptionFeature > getSubscriptionOptions()so it returns anSubscriptionOptions.emptySettings > Privacy Pro > Get Privacy ProOptional:
Test with a custom privacy config URL > Flags available in: duckduckgo/privacy-configuration#1887