Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom DNS for iOS #2459

Closed
wants to merge 2 commits into from
Closed

Custom DNS for iOS #2459

wants to merge 2 commits into from

Conversation

quanganhdo
Copy link
Member

Task/Issue URL: https://app.asana.com/0/42792087274227/1206466386865313/f
Tech Design URL:
CC:

Description:

This PR adds a Custom DNS setting to NetP.

Steps to test this PR:

  1. Go to Network Protection menu > VPN Settings > Custom DNS
  2. Fill in a custom DNS server (e.g. 1.1.1.1)
  3. Apply the change
  4. Profit

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant