Fix site: queries escaping with iOS 17 SDK (#640)
#2402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
dus7
changed the title
site: queries escaping with iOS 17 SDK (#640)
samsymons
added a commit
that referenced
this pull request
Jan 30, 2024
# By dependabot[bot] (1) and others # Via GitHub * main: Reenable toggle on disallowing vpn (#2404) Bump BrowserServicesKit to 103.0.2 (#2393) Fix the alpha build VPN extension embed script (#2396) Fix `site:` queries escaping with iOS 17 SDK (#640) (#2402) Prepare release script updates (#2389) Adding lastSentDate to broken site report (#2320) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2382) Skip 'Make Release Build' GHA job for Dependabot PRs (#2399) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/414235014887631/1206343150540010/f
Description:
Linking to iOS 17 SDK modifies how URLs are being parsed and escaped (see release notes). This change re-uses the solution done for macOS.
Steps to test this PR:
See PR in BSK