Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update .strings file #2325

Merged
merged 1 commit into from
Jan 11, 2024
Merged

Update .strings file #2325

merged 1 commit into from
Jan 11, 2024

Conversation

bwaresiak
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/414235014887631/1204622631026489/f
Tech Design URL:
CC:

Description:

Update .strings file after recent merge.

Steps to test this PR:

Ensure .strings are up to date.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@brindy brindy self-requested a review January 11, 2024 12:05
Copy link
Contributor

@brindy brindy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bwaresiak bwaresiak merged commit 1e57c5a into main Jan 11, 2024
10 checks passed
@bwaresiak bwaresiak deleted the bartek/update-strings-file branch January 11, 2024 12:29
ayoy pushed a commit that referenced this pull request Jan 11, 2024
Task/Issue URL: https://app.asana.com/0/414235014887631/1204622631026489/f
Tech Design URL:
CC:

Description:

Update .strings file after recent merge.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants