Adding lastSentDate to broken site report #2320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
mallexxx
reviewed
Jan 12, 2024
mallexxx
reviewed
Jan 12, 2024
mallexxx
approved these changes
Jan 12, 2024
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
jaceklyp
reviewed
Jan 25, 2024
federicocappelli
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 29, 2024
Task/Issue URL: https://app.asana.com/0/1205842942115003/1205860617092609/f https://app.asana.com/0/1163321984198618/1206045984561862/f iOS PR: duckduckgo/iOS#2320 macOS PR: duckduckgo/macos-browser#2041 What kind of version bump will this require?: Major Description: This PR contains the code related to two separate, but overlapping, tasks: https://app.asana.com/0/1205842942115003/1205860617092609/f: Remove the native report broken site form inside the general feedback and replace it with the web privacy dashboard https://app.asana.com/0/1163321984198618/1206045984561862/f: Store locally a broken website report history and send a lastSentDate field in the report broken site pixel. This task includes the migration to all report broken site business logic and models to BSK. Privacy dashboard code related to web breakage is now unit tested
# Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved # DuckDuckGo/en.lproj/Localizable.strings # LocalPackages/DuckUI/Package.swift # LocalPackages/SyncUI/Package.swift # LocalPackages/Waitlist/Package.swift
samsymons
added a commit
that referenced
this pull request
Jan 30, 2024
# By dependabot[bot] (1) and others # Via GitHub * main: Reenable toggle on disallowing vpn (#2404) Bump BrowserServicesKit to 103.0.2 (#2393) Fix the alpha build VPN extension embed script (#2396) Fix `site:` queries escaping with iOS 17 SDK (#640) (#2402) Prepare release script updates (#2389) Adding lastSentDate to broken site report (#2320) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2382) Skip 'Make Release Build' GHA job for Dependabot PRs (#2399) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1163321984198618/1205860617092609/f
Description:
Goal
Why Now?
Steps to test this PR:
Note: 30-days history element expiry can't be easily tested manually, we use unit tests for that.
Device Testing:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template