Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps BrowserServicesKit 100.0.3 + content-scope-scripts 4.59.0 #2304

Merged
merged 1 commit into from
Jan 5, 2024

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Jan 5, 2024

Task/Issue URL: https://app.asana.com/0/0/1206197024515459/f
Tech Design URL:
CC:

Description:

No functional changes here, just a version bump to match duckduckgo/macos-browser#1982

Steps to test this PR:
1.
2.

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@shakyShane
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@shakyShane shakyShane requested a review from ayoy January 5, 2024 07:32
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😎

@shakyShane shakyShane merged commit e62c7ea into main Jan 5, 2024
12 checks passed
@shakyShane shakyShane deleted the shane/duckplayer-nav-loop branch January 5, 2024 22:38
samsymons added a commit that referenced this pull request Jan 8, 2024
* main:
  deps BrowserServicesKit 100.0.3 + content-scope-scripts 4.59.0 (#2304)
  bookmarks migration refactor (#2236)
  respect system theme on launch (#2302)
  remove unused pixels (#2303)
  Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2285)
  Update Sync End-to-End tests (#2300)
  Allow calculations in the address bar (#2298)
  Remove trailing space in unableToCreateRecoveryPDF error (#2297)
  Update errors (#2283)
  BSK update for autofill never prompt to save for site feature (#2280)
  Add timeouts to the alpha job.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants