Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable NetP in production builds #2223

Closed
wants to merge 2 commits into from

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Dec 6, 2023

Task/Issue URL: https://app.asana.com/0/0/1206108886603214/f
Tech Design URL:
CC:

Description:

This PR enables NetP in production.

I am deliberately keeping the NETWORK_PROTECTION flag in place for now in the off chance that something comes up in review that prevents this from shipping, we need to have the ability to shut it off if necessary.

Steps to test this PR:

  1. Create an ad-hoc build of the app (or get one pre-made here!)
  2. Make sure your device is using United States as its region
  3. Make sure NetP appears in settings, and that you can proceed through the waitlist and start the VPN

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons samsymons requested a review from graeme December 6, 2023 05:12
@jaceklyp jaceklyp deleted the branch develop December 6, 2023 15:48
@jaceklyp jaceklyp closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants