Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autofill prompt icon + copy updates #2167

Merged

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Nov 16, 2023

Task/Issue URL: https://app.asana.com/0/72649045549333/1205786958985456/f
Tech Design URL:
CC:

Description:
Removes the website favicon + url at the top of the autofill prompts and add app icon to the top of all autofill prompts. Also updates copy to replace the word logins with passwords

Steps to test this PR:

  1. Visit https://fill.dev/form/login-simple and enter any username & password
  2. Confirm the Save a Login prompt has the same layout & copy as this:
  1. Tap Save Password
  2. Go back to https://fill.dev/form/login-simple and confirm the Use Saved Login prompt has the same layout & copy as this:
  1. On https://fill.dev/form/login-simple enter the username of your saved login, but enter a different password
  2. Confirm the Update Password prompt has the same layout & copy as this:
  1. Go to https://news.ycombinator.com/login and in the login form enter a dummy password and tap 'login'
  2. Confirm the Save Password prompt has the same layout & copy as this:
  1. Now enter a dummy username in the same form and tap 'login'
  2. Confirm the Update Username prompt has the same layout & copy as this:
  1. Visit https://fill.dev/form/registration-email and tap the key icon in the password field
  2. Confirm the Generated Password prompt has the same layout & copy as this:
  1. Review the translated strings, confirming 4 have been modified and 2 (now unused) are deleted

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested review from a team and THISISDINOSAUR and removed request for a team November 16, 2023 10:42
Copy link
Contributor

@THISISDINOSAUR THISISDINOSAUR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

  • I had to manually turn autofill on, I assume that's expected at this point?
  • Somewhat unrelated to this PR, and I don't know if there's anything we can do about it, and it's pretty marginal given keyboard usage with iOS (I'll forgive you if you've stopped reading at this point 😅), but when I used tab to switch text fields, I didn't get the generate password prompt.

@amddg44
Copy link
Contributor Author

amddg44 commented Nov 16, 2023

  • I had to manually turn autofill on, I assume that's expected at this point?
    Ah, I think that's because embedded ios-config.json file still only has the rollout at 10%; re-launching the app should pick up + apply the latest downloaded json and then would be on by default 😅
  • Somewhat unrelated to this PR, and I don't know if there's anything we can do about it, and it's pretty marginal given keyboard usage with iOS (I'll forgive you if you've stopped reading at this point 😅), but when I used tab to switch text fields, I didn't get the generate password prompt.
  • noted, thanks!

@amddg44 amddg44 merged commit 42a8c09 into anya/autofill-never-prompt-save Nov 16, 2023
9 checks passed
@amddg44 amddg44 deleted the anya/autofill-prompt-updates-icon branch November 16, 2023 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants