Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

switch to true|false for protectionsState param #2137

Merged
merged 2 commits into from
Nov 10, 2023
Merged

switch to true|false for protectionsState param #2137

merged 2 commits into from
Nov 10, 2023

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Nov 9, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/0/1205915950517976/f
Tech Design URL:
CC:

Description:

Switching to true|false instead of 1|0 for cross-platform consistency. See the parent task https://app.asana.com/0/1201141132935289/1205644489547731

Steps to test this PR

  • Submit the breakage form with protections on
  • Verify that the breakage form pixel param protectionsState is the string true
  • Submit the breakage form with protections off
  • Verify that the breakage form pixel param protectionsState is the string false

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@shakyShane
Copy link
Collaborator Author

Current dependencies on/for this PR:

This stack of pull requests is managed by Graphite.

@shakyShane shakyShane requested a review from miasma13 November 9, 2023 13:10
miasma13
miasma13 approved these changes Nov 10, 2023
View reviewed changes
Copy link
Contributor

@miasma13 miasma13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks fine but please fix tests

@shakyShane shakyShane merged commit 9ad737c into develop Nov 10, 2023
9 checks passed
@shakyShane shakyShane deleted the shane/bool branch November 10, 2023 09:50
samsymons added a commit that referenced this pull request Nov 10, 2023
@samsymons
Merge branch 'develop' into sam/hack-days-netp-widget
0f6d0e3 
* develop:
  Sync form factor specific favorites (#2029)
  Add Sync e2e test flows (#2127)
  switch to true|false for protectionsState param (#2137)
samsymons added a commit that referenced this pull request Nov 12, 2023
@samsymons
Merge branch 'develop' into sam/vpn-waitlist
7a5a466 
# By Dominik Kapusta (1) and others
# Via GitHub
* develop:
  Add DesignResourcesKit to SyncUI (#2147)
  Sync form factor specific favorites (#2029)
  Add Sync e2e test flows (#2127)
  switch to true|false for protectionsState param (#2137)

# Conflicts:
#	DuckDuckGo/AppDelegate.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miasma13 miasma13 miasma13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shakyShane @miasma13