Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sync e2e test flows #2127

Merged
merged 18 commits into from
Nov 10, 2023
Merged

Add Sync e2e test flows #2127

merged 18 commits into from
Nov 10, 2023

Conversation

loremattei
Copy link
Contributor

@loremattei loremattei commented Nov 3, 2023

Task/Issue URL: https://app.asana.com/0/0/1205914590479611/f
Tech Design URL:
CC:

Description:

This PR adds the critical e2e tests identified in the task above.

Most of them will need an update soon as the new sync setup flow is implemented, but the most interesting part of this PR is that it sets up the integration with the JS test script, so it's still worth it to merge it.

Steps to test this PR:

  1. Verify CI is green.

To test locally:
2. Download https://github.com/duckduckgo/sync_crypto (You want to use this branch if the PR has not been merged yet).
3. Run node index.js and copy the recovery code that the script outputs.
4. Open an iOS simulator and install the iOS app.
5. Run maestro test -e CODE=<Paste the code here> ./.maestro/sync_tests.
6. When finished, delete the test sync account (The easiest way to do it is using the dedicated option in the iOS app).


Internal references:

Software Engineering Expectations
Technical Design Template

@loremattei loremattei marked this pull request as ready for review November 10, 2023 09:21
Copy link
Contributor

@ayoy ayoy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I couldn't test locally because I don't have Xcode 14.3, but I went through tests code and it makes perfect sense, and also the CI is green so I think it's good to go. Thanks for handling this @loremattei!

.github/workflows/sync-end-to-end.yml Outdated Show resolved Hide resolved
@loremattei loremattei merged commit 0389ed6 into develop Nov 10, 2023
9 checks passed
@loremattei loremattei deleted the loremattei/sync-e2e-critical-path branch November 10, 2023 14:41
samsymons added a commit that referenced this pull request Nov 10, 2023
* develop:
  Sync form factor specific favorites (#2029)
  Add Sync e2e test flows (#2127)
  switch to true|false for protectionsState param (#2137)
samsymons added a commit that referenced this pull request Nov 12, 2023
# By Dominik Kapusta (1) and others
# Via GitHub
* develop:
  Add DesignResourcesKit to SyncUI (#2147)
  Sync form factor specific favorites (#2029)
  Add Sync e2e test flows (#2127)
  switch to true|false for protectionsState param (#2137)

# Conflicts:
#	DuckDuckGo/AppDelegate.swift
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants