-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Sync e2e test flows #2127
Merged
Merged
Add Sync e2e test flows #2127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ec55a27.
ayoy
reviewed
Nov 10, 2023
ayoy
approved these changes
Nov 10, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I couldn't test locally because I don't have Xcode 14.3, but I went through tests code and it makes perfect sense, and also the CI is green so I think it's good to go. Thanks for handling this @loremattei!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/0/1205914590479611/f
Tech Design URL:
CC:
Description:
This PR adds the critical e2e tests identified in the task above.
Most of them will need an update soon as the new sync setup flow is implemented, but the most interesting part of this PR is that it sets up the integration with the JS test script, so it's still worth it to merge it.
Steps to test this PR:
To test locally:
2. Download https://github.com/duckduckgo/sync_crypto (You want to use this branch if the PR has not been merged yet).
3. Run
node index.js
and copy the recovery code that the script outputs.4. Open an iOS simulator and install the iOS app.
5. Run
maestro test -e CODE=<Paste the code here> ./.maestro/sync_tests
.6. When finished, delete the test sync account (The easiest way to do it is using the dedicated option in the iOS app).
Internal references:
Software Engineering Expectations
Technical Design Template