Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e test for email protection deep-links #2123

Merged
merged 2 commits into from
Nov 3, 2023

Conversation

loremattei
Copy link
Contributor

@loremattei loremattei commented Nov 2, 2023

Task/Issue URL: https://app.asana.com/0/0/1205692227651013/f
Tech Design URL:
CC:

Description:

Add a simple e2e test to verify that the e-mail protection menu entry correctly navigates to the e-mail protection website.

Steps to test this PR:
GitHub

  1. Verify that CI is green

Local
3. Start a simulator.
4. Install the current version of the app.
5. Run maestro test ./.maestro/release_tests/emailprotection.yaml and verify the test passes.


Internal references:

Software Engineering Expectations
Technical Design Template

@loremattei loremattei marked this pull request as ready for review November 2, 2023 12:22
@Bunn Bunn self-requested a review November 2, 2023 13:54
Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is green, all tests are passing. LGTM!

@loremattei loremattei merged commit 9210ed9 into develop Nov 3, 2023
11 checks passed
@loremattei loremattei deleted the loremattei/add-emailprotection-deeplinks branch November 3, 2023 13:46
samsymons added a commit that referenced this pull request Nov 5, 2023
* develop:
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
  Release 7.95.0 (#2122)
  Add toggling of NetP Notifications to iOS (#2112)
  Fix for deeplink crash when preparing webview preview (#2116)
  Integrates the latest DBP changes in BSK (#2108)
  Switch to next phase of new experiment for UA (#2118)
samsymons added a commit that referenced this pull request Nov 8, 2023
* develop:
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
  Release 7.95.0 (#2122)
  Add toggling of NetP Notifications to iOS (#2112)
  Fix for deeplink crash when preparing webview preview (#2116)
  Integrates the latest DBP changes in BSK (#2108)
  Switch to next phase of new experiment for UA (#2118)
samsymons added a commit that referenced this pull request Nov 9, 2023
* develop:
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
samsymons added a commit that referenced this pull request Nov 10, 2023
* develop:
  Support environment setting (#2140)
  Update BSK (#2136)
  Update BSK for NetP change (#2134)
  Update test to match exact tracker (#2133)
  Avoid AppTP DB initialization when disabled (#2090)
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants