Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrates the latest DBP changes in BSK #2108

Merged
merged 6 commits into from
Oct 30, 2023

Conversation

diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Oct 19, 2023

Task/Issue URL: https://app.asana.com/0/0/1205755216985387/f

BSK PR: duckduckgo/BrowserServicesKit#532
macOS PR: duckduckgo/macos-browser#1751

Description

Integrates the latest BSK changes.

Testing

Just ensure the app builds fine and unit tests succeed.


Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍🏼

@diegoreymendez diegoreymendez marked this pull request as ready for review October 20, 2023 16:43
@diegoreymendez diegoreymendez merged commit 784f05a into develop Oct 30, 2023
9 checks passed
@diegoreymendez diegoreymendez deleted the diego/integrate-latest-bsk-changes-for-dbp branch October 30, 2023 23:23
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Oct 31, 2023
Task/Issue URL: https://app.asana.com/0/0/1205630360631958/f

BSK PR: duckduckgo/BrowserServicesKit#532
iOS PR: duckduckgo/iOS#2108

## Description

Adds the background agent app for DBP.
diegoreymendez added a commit to duckduckgo/macos-browser that referenced this pull request Nov 1, 2023
Task/Issue URL: https://app.asana.com/0/0/1205630360631958/f

BSK PR: duckduckgo/BrowserServicesKit#532
iOS PR: duckduckgo/iOS#2108

## Description

Adds the background agent app for DBP.
samsymons added a commit that referenced this pull request Nov 5, 2023
* develop:
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
  Release 7.95.0 (#2122)
  Add toggling of NetP Notifications to iOS (#2112)
  Fix for deeplink crash when preparing webview preview (#2116)
  Integrates the latest DBP changes in BSK (#2108)
  Switch to next phase of new experiment for UA (#2118)
samsymons added a commit that referenced this pull request Nov 8, 2023
* develop:
  re-enable keyboard shortcuts (#2132)
  fix favorite launch with keyboard bug (#2131)
  Fix syncing empty favorites folders (#2121)
  kill variant when receiving atb update (#2130)
  Adding 'protectionsState' to breakage form submission (#2120)
  Release 7.96.0 (#2128)
  Update remote messaging production url (#2124)
  Alert user about abnormal app conditions (#2110)
  Add e2e test for email protection deep-links (#2123)
  Update to config v4 (#2114)
  Release 7.95.0 (#2122)
  Add toggling of NetP Notifications to iOS (#2112)
  Fix for deeplink crash when preparing webview preview (#2116)
  Integrates the latest DBP changes in BSK (#2108)
  Switch to next phase of new experiment for UA (#2118)
samsymons added a commit that referenced this pull request Nov 9, 2023
* develop:
  Release 7.95.0 (#2122)
  Add toggling of NetP Notifications to iOS (#2112)
  Fix for deeplink crash when preparing webview preview (#2116)
  Integrates the latest DBP changes in BSK (#2108)
  Switch to next phase of new experiment for UA (#2118)
  Update BSK with autofill 9.0.0 (#2103)
  Add an “Open VPN Settings” quick action (#2089)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants