Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify favicon fetching #2078

Closed
wants to merge 2 commits into from
Closed

Simplify favicon fetching #2078

wants to merge 2 commits into from

Conversation

samsymons
Copy link
Contributor

@samsymons samsymons commented Oct 9, 2023 •
edited
Loading

Task/Issue URL: https://app.asana.com/0/414235014887631/1205676278268780/f
Tech Design URL:
CC:

Description:

This PR simplifies favicon fetching.

Steps to test this PR:

  1. Favorite a website and make sure a favicon is displayed in the new tab page and widget

Copy Testing:

  • Use of correct apostrophes in new copy, ie ’ rather than '

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme
Internal references:

Software Engineering Expectations
Technical Design Template

@samsymons
Simplify Favicons.swift.
98f7daf
@samsymons
Merge branch 'develop' into sam/simplify-favicon-fetching
e0ee2fa 
* develop:
  Add parameter to multiple Autofill pixels (#2032)
  Removes iOS phased rollout dry run pixel (#2064)
@samsymons samsymons requested a review from brindy October 9, 2023 03:52
@samsymons
Copy link
Contributor Author

Closing this until we know whether it's needed

@samsymons samsymons closed this Oct 15, 2023
@samsymons samsymons deleted the sam/simplify-favicon-fetching branch March 1, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brindy brindy Awaiting requested review from brindy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@samsymons