Replace insecure self.url?.absoluteString with secure alternative #2067
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
self.url?.absoluteString ?? ""
withframe.securityOrigin.host
as a more secure fallback value for JSWebAlerts.Task/Issue URL: https://app.asana.com/0/414709148257752/1205572557120542
Additional Context: https://app.asana.com/0/0/1205594619842512/f
Description:
Our JSWebAlert is showing the wrong origin when falling back on self.url?.absoluteString. This is resulting in JS alerts being generated with the text:
Message from originX.com
when in fact the message is resulting from JS executing inoriginY.com
.Steps to test this PR:
Copy Testing:
’
rather than'
Orientation Testing:
Device Testing:
OS Testing:
Theme Testing:
Internal references:
Software Engineering Expectations
Technical Design Template