Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Login details auth state check to be in line with the main Login screen #2002

Merged
merged 1 commit into from
Sep 11, 2023

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 11, 2023

Task/Issue URL: https://app.asana.com/0/0/1205463416606385/f
Tech Design URL:
CC:

Description:
Applies same authentication logic check to the details screen as to it's parent

Steps to test this PR:

  1. Attempt to access the Logins screen but do not allow authentication to succeed.
  2. Cancel the biometric prompt and the Login screen should dismiss.
  3. Attempt to access the Logins screen again and confirm you are again prompted to authenticate
  4. Minimise the app and again try to access the Logins screen from the menu and confirm you are again prompted to authenticate
  5. Authenticate and tap into the details of one of the Logins
  6. Swipe down to dismiss the Logins screens
  7. Immediately access Logins again via the menu and you should still be on the Details screen and not prompted for authentication (still within grace period)

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested a review from bwaresiak September 11, 2023 13:03
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amddg44 amddg44 merged commit 4fe5203 into develop Sep 11, 2023
10 checks passed
@amddg44 amddg44 deleted the anya/fix-autofill-auth-details branch September 11, 2023 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants