Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add authentication state check when enabling grace period #1999

Closed
wants to merge 1 commit into from

Conversation

amddg44
Copy link
Contributor

@amddg44 amddg44 commented Sep 11, 2023

Task/Issue URL: https://app.asana.com/0/414709148257752/1205462483244180/f
Tech Design URL:
CC:

Description:
Adds check of authenticator state when determining whether or not to enable the login grace period

Steps to test this PR:

  1. Attempt to access the Logins screen but do not authentication to succeed.
  2. Cancel the biometric prompt and the Login screen should dismiss.
  3. Attempt to access the Logins screen again and confirm you are again prompted to authenticate
  4. Minimise the app and again try to access the Logins screen and confirm you are again prompted to authenticate
  5. Access the Logins screen and this time allow authentication to succeed. Confirm you can now see the list of logins
  6. Back out of the Logins screen and immediately try to access it again. This time you should see the list of logins without an authentication prompt (grace period is active)
  7. Back out of the Logins screen again and wait 20 seconds before attempting to access the screen again. This time you should be prompted to authenticate (grace period has expired)

Copy Testing:

  • Use of correct apostrophes in new copy, ie rather than '

Orientation Testing:

  • Portrait
  • Landscape

Device Testing:

  • iPhone SE (1st Gen)
  • iPhone 8
  • iPhone X
  • iPhone 14 Pro
  • iPad

OS Testing:

  • iOS 14
  • iOS 15
  • iOS 16

Theme Testing:

  • Light theme
  • Dark theme

Internal references:

Software Engineering Expectations
Technical Design Template

@amddg44 amddg44 requested a review from bwaresiak September 11, 2023 09:35
Copy link
Collaborator

@bwaresiak bwaresiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@amddg44 amddg44 closed this Sep 11, 2023
@amddg44 amddg44 deleted the anya/fix-autofill-auth-issue branch September 11, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants