Merge branch 'develop' into sam/netp-quick-action

* develop: address bar position (#2072) Fix privacy tests (#2097) Add note about Danger matching rules (#2087) Release 7.93.0 (#2096) Update tabs tests (#2088)
duckduckgo · Oct 17, 2023 · e15e3d7 · e15e3d7
2 parents 8a74193 + 6261549
commit e15e3d7
Show file tree

Hide file tree

Showing 52 changed files with 1,332 additions and 938 deletions.
diff --git a/.maestro/privacy_tests/06_multi-tab.yaml b/.maestro/privacy_tests/06_multi-tab.yaml
@@ -70,10 +70,8 @@ tags:
 - tapOn: "Done"
 - assertVisible:
     text: "Publisher site"
-- assertVisible:
-    id: "Tabs"
-- tapOn: 
-    id: "Tabs"   
+- assertVisible: Tab Switcher
+- tapOn: Tab Switcher 
 - assertVisible:
     id: "Add"
 - tapOn:

diff --git a/.maestro/release_tests/tabs.yaml b/.maestro/release_tests/tabs.yaml
@@ -20,7 +20,7 @@ tags:
     id: "searchEntry"
 - tapOn: 
     id: "searchEntry"
-- inputText: "https://privacy-test-pages.glitch.me"
+- inputText: "https://privacy-test-pages.site"
 - pressKey: Enter
 
 # Manage onboarding
@@ -34,10 +34,8 @@ tags:
 - assertVisible: ".*Privacy Test Pages.*"
 
 # Add tab
-- assertVisible:
-    id: "Tabs"
-- tapOn: 
-    id: "Tabs"
+- assertVisible: Tab Switcher
+- tapOn: Tab Switcher
 - assertVisible: ".*Privacy Test Pages.*"
 - assertVisible: 
     id: "Add"
@@ -52,23 +50,19 @@ tags:
 - assertVisible: "Search engine"
 
 # Switch Tab
-- assertVisible:
-    id: "Tabs"
-- tapOn: 
-    id: "Tabs"
+- assertVisible: Tab Switcher
+- tapOn: Tab Switcher
 - assertVisible: ".*Privacy Test Pages.*"
 - assertVisible: ".*Ad Click Flow.*"
 - assertVisible: "2 Private Tabs"
-- tapOn: "Open \"Privacy Test Pages - Home\" at privacy-test-pages.glitch.me"
+- tapOn: "Open \"Privacy Test Pages - Home\" at privacy-test-pages.site"
 - assertNotVisible: ".*Ad Click Flow.*"
 - assertVisible: ".*Privacy Test Pages.*"
 - tapOn: "Refresh Page"
 
 # Close Tab
-- assertVisible:
-    id: "Tabs"
-- tapOn: 
-    id: "Tabs"
+- assertVisible: Tab Switcher
+- tapOn: Tab Switcher
 - assertVisible: ".*Privacy Test Pages.*"
 - assertVisible: ".*Ad Click Flow.*"
 - assertVisible: "2 Private Tabs"

diff --git a/Core/AppPrivacyConfigurationDataProvider.swift b/Core/AppPrivacyConfigurationDataProvider.swift
@@ -23,8 +23,8 @@ import BrowserServicesKit
 final public class AppPrivacyConfigurationDataProvider: EmbeddedDataProvider {
 
     public struct Constants {
-        public static let embeddedDataETag = "\"54efb258435567856e087913f93d43df\""
-        public static let embeddedDataSHA = "d0f9c70c5baba23a0966b277f8b4c949ecf01612558a50d2bda720fe1919b43f"
+        public static let embeddedDataETag = "\"81da520221d37e6398ea3d8940595810\""
+        public static let embeddedDataSHA = "19766ed7e598cdc123c9db702264b99d0cff5ddfb2ed226fba85b06d304f7e0b"
     }
 
     public var embeddedDataEtag: String {

diff --git a/Core/AppURLs.swift b/Core/AppURLs.swift
@@ -33,6 +33,9 @@ public extension URL {
     static let aboutLink = URL(string: AppDeepLinkSchemes.quickLink.appending("\(ddg.host!)/about"))!
 
     static let surrogates = URL(string: "\(staticBase)/surrogates.txt")!
+
+    // The following URLs shall match the ones in update_embedded.sh. 
+    // Danger checks that the URLs match on every PR. If the code changes, the regex that Danger uses may need an update.
     static let privacyConfig = URL(string: "\(staticBase)/trackerblocking/config/v3/ios-config.json")!
     static let trackerDataSet = URL(string: "\(staticBase)/trackerblocking/v5/current/ios-tds.json")!
     static let bloomFilter = URL(string: "\(staticBase)/https/https-mobile-v2-bloom.bin")!

diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift
@@ -245,6 +245,9 @@ extension Pixel {
 
         case autofillJSPixelFired(_ pixel: AutofillUserScript.JSPixel)
 
+        case navigationbarPositionBottom
+        case navigationBarPositionTop
+
         case secureVaultInitError
         case secureVaultError
 
@@ -576,7 +579,10 @@ extension Pixel.Event {
 
         case .autocompleteSelectedLocal: return "m_au_l"
         case .autocompleteSelectedRemote: return "m_au_r"
-
+
+        case .navigationbarPositionBottom: return "m_seturlbar_bottom"
+        case .navigationBarPositionTop: return "m_seturlbar_top"
+
         case .feedbackPositive: return "mfbs_positive_submit"
         case .feedbackNegativePrefix(category: let category): return "mfbs_negative_\(category)"
 

diff --git a/Core/UserDefaultsPropertyWrapper.swift b/Core/UserDefaultsPropertyWrapper.swift
@@ -99,6 +99,9 @@ public struct UserDefaultsWrapper<T> {
         case syncEnvironment = "com.duckduckgo.ios.sync-environment"
 
         case networkProtectionDebugOptionAlwaysOnDisabled = "com.duckduckgo.network-protection.always-on.disabled"
+
+        case addressBarPosition = "com.duckduckgo.ios.addressbarposition"
+        case showFullSiteAddress = "com.duckduckgo.ios.showfullsiteaddress"
     }
 
     private let key: Key