Release PR: Check for the negative attribution case (#3311)

Task/Issue URL: https://app.asana.com/0/1199333091098016/1208213972615180/f Tech Design URL: CC: Description: This PR updates the attribution checker to handle the false case.
duckduckgo · Sep 5, 2024 · dddd0e2 · dddd0e2
1 parent 8bd7fc5
commit dddd0e2
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 13 deletions.
diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift
@@ -723,6 +723,7 @@ extension Pixel {
 
         // MARK: Apple Ad Attribution
         case appleAdAttribution
+        case appleAdAttributionNotAttributed
 
         // MARK: Secure Vault
         case secureVaultL1KeyMigration
@@ -1431,6 +1432,7 @@ extension Pixel.Event {
 
         // MARK: - Apple Ad Attribution
         case .appleAdAttribution: return "m_apple-ad-attribution"
+        case .appleAdAttributionNotAttributed: return "m_apple-ad-attribution_not-attributed"
 
         // MARK: - User behavior
         case .userBehaviorReloadTwiceWithin12Seconds: return "m_reload-twice-within-12-seconds"

diff --git a/DuckDuckGo/AdAttribution/AdAttributionPixelReporter.swift b/DuckDuckGo/AdAttribution/AdAttributionPixelReporter.swift
@@ -56,17 +56,17 @@ final actor AdAttributionPixelReporter {
         }
 
         if let (token, attributionData) = await self.attributionFetcher.fetch() {
-            if attributionData.attribution {
-                let parameters = self.pixelParametersForAttribution(attributionData, attributionToken: token)
-                do {
-                    try await pixelFiring.fire(
-                        pixel: .appleAdAttribution,
-                        withAdditionalParameters: parameters,
-                        includedParameters: [.appVersion, .atb]
-                    )
-                } catch {
-                    return false
-                }
+            let event: Pixel.Event = attributionData.attribution ? .appleAdAttribution : .appleAdAttributionNotAttributed
+            let parameters = attributionData.attribution ? self.pixelParametersForAttribution(attributionData, attributionToken: token) : [:]
+
+            do {
+                try await pixelFiring.fire(
+                    pixel: event,
+                    withAdditionalParameters: parameters,
+                    includedParameters: [.appVersion, .atb]
+                )
+            } catch {
+                return false
             }
 
             await fetcherStorage.markAttributionReportSuccessful()

diff --git a/DuckDuckGoTests/AdAttributionPixelReporterTests.swift b/DuckDuckGoTests/AdAttributionPixelReporterTests.swift
@@ -124,13 +124,16 @@ final class AdAttributionPixelReporterTests: XCTestCase {
         XCTAssertNil(pixelAttributes["ad_id"])
     }
 
-    func testPixelNotFiredAndMarksReport_WhenAttributionFalse() async {
+    func testNotAttributedPixelFiredAndMarkedReported_WhenAttributionFalse() async throws {
         let sut = createSUT()
         attributionFetcher.fetchResponse = ("example", AdServicesAttributionResponse(attribution: false))
 
         let result = await sut.reportAttributionIfNeeded()
 
-        XCTAssertNil(PixelFiringMock.lastPixel)
+        let pixelAttributes = try XCTUnwrap(PixelFiringMock.lastParams)
+
+        XCTAssertEqual(pixelAttributes, [:])
+        XCTAssertEqual(PixelFiringMock.lastPixel?.name, "m_apple-ad-attribution_not-attributed")
         XCTAssertTrue(fetcherStorage.wasAttributionReportSuccessful)
         XCTAssertTrue(result)
     }