Skip to content

Commit

Permalink
Merge branch 'main' into sam/enable-netp-in-production
Browse files Browse the repository at this point in the history
* main:
  Report macOS NetP connection attempts & tunnel failures (#2234)
  Always use black and white colors for the QR code (#2248)
  Update BSK with autofill 10.0.1 (#2245)
  Ensure that LinkPresentation framework is called on main thread (#2241)
  expose window.print handler to page world (#2243)
  Updates BSK (#2239)
  Add Geoswitching pixels (#2235)
  Fix spacing between buttons (#2237)
  Update all references to develop branch with main (#2231)
  Update TRK (#2200)
  Breakage report improvements (#2197)
  • Loading branch information
samsymons committed Dec 9, 2023
2 parents e5fac5c + 8bbc638 commit d041c90
Show file tree
Hide file tree
Showing 155 changed files with 2,830 additions and 5,193 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/adhoc.yml
Original file line number Diff line number Diff line change
Expand Up @@ -87,4 +87,4 @@ jobs:
run: |
curl -s "https://app.asana.com/api/1.0/tasks/${{ steps.get-task-id.outputs.task_id }}/attachments" \
-H "Authorization: Bearer ${{ secrets.ASANA_ACCESS_TOKEN }}" \
--form "file=@${{ env.ipa_path }};type=application/zip"
--form "file=@${{ env.ipa_path }};type=application/zip"
6 changes: 3 additions & 3 deletions .github/workflows/alpha.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,11 @@ jobs:

steps:

- name: Assert develop branch
- name: Assert main branch
run: |
case "${{ github.ref }}" in
*develop) ;;
*) echo "👎 Not develop branch"; exit 1 ;;
*main) ;;
*) echo "👎 Not main branch"; exit 1 ;;
esac
- name: Register SSH keys for access to certificates
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/pr.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: PR Checks

on:
push:
branches: [ develop, "release/**" ]
branches: [ main, "release/**" ]
pull_request:

jobs:
Expand Down Expand Up @@ -114,7 +114,7 @@ jobs:
| xargs -L 1 ./scripts/report-failed-unit-test.sh -s ${{ vars.APPLE_CI_FAILING_TESTS_FAILED_TESTS_SECTION_ID }}
- name: Fetch latest commit author
if: always() && github.ref_name == 'develop'
if: always() && github.ref_name == 'main'
id: fetch_commit_author
env:
GH_TOKEN: ${{ github.token }}
Expand Down Expand Up @@ -189,7 +189,7 @@ jobs:
name: Create Asana Task
needs: [swiftlint, unit-tests, shellcheck, release-build]

if: failure() && github.ref_name == 'develop' && github.run_attempt == 1
if: failure() && github.ref_name == 'main' && github.run_attempt == 1

runs-on: ubuntu-latest

Expand All @@ -206,7 +206,7 @@ jobs:
name: Close Asana Task
needs: [swiftlint, unit-tests, shellcheck, release-build]

if: success() && github.ref_name == 'develop' && github.run_attempt > 1
if: success() && github.ref_name == 'main' && github.run_attempt > 1

runs-on: ubuntu-latest

Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -73,3 +73,4 @@ fastlane/test_output
# DuckDuckGo

Configuration/ExternalDeveloper.xcconfig
scripts/assets
25 changes: 20 additions & 5 deletions Core/PixelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,10 @@ extension Pixel {
case forgetAllDataCleared

case privacyDashboardOpened
case privacyDashboardProtectionDisabled
case privacyDashboardProtectionEnabled

case dashboardProtectionAllowlistAdd
case dashboardProtectionAllowlistRemove

case privacyDashboardReportBrokenSite
case privacyDashboardPixelFromJS(rawPixel: String)

Expand Down Expand Up @@ -311,6 +313,7 @@ extension Pixel {
// MARK: Network Protection

case networkProtectionActiveUser
case networkProtectionNewUser

case networkProtectionRekeyCompleted
case networkProtectionLatency
Expand Down Expand Up @@ -372,6 +375,11 @@ extension Pixel {
case networkProtectionWaitlistNotificationShown
case networkProtectionWaitlistNotificationLaunched

case networkProtectionGeoswitchingOpened
case networkProtectionGeoswitchingSetNearest
case networkProtectionGeoswitchingSetCustom
case networkProtectionGeoswitchingNoLocations

// MARK: remote messaging pixels

case remoteMessageShown
Expand Down Expand Up @@ -553,9 +561,10 @@ extension Pixel.Event {
case .forgetAllDataCleared: return "mf_dc"

case .privacyDashboardOpened: return "mp"

case .privacyDashboardProtectionDisabled: return "mp_wla"
case .privacyDashboardProtectionEnabled: return "mp_wlr"

case .dashboardProtectionAllowlistAdd: return "mp_wla"
case .dashboardProtectionAllowlistRemove: return "mp_wlr"

case .privacyDashboardReportBrokenSite: return "mp_rb"
case .privacyDashboardPixelFromJS(let rawPixel): return rawPixel

Expand Down Expand Up @@ -833,6 +842,7 @@ extension Pixel.Event {
// MARK: Network Protection pixels

case .networkProtectionActiveUser: return "m_netp_daily_active_d"
case .networkProtectionNewUser: return "m_netp_daily_active_u"
case .networkProtectionRekeyCompleted: return "m_netp_rekey_completed"
case .networkProtectionLatency: return "m_netp_latency"
case .networkProtectionTunnelConfigurationNoServerRegistrationInfo: return "m_netp_tunnel_config_error_no_server_registration_info"
Expand Down Expand Up @@ -886,6 +896,11 @@ extension Pixel.Event {
case .networkProtectionWaitlistNotificationShown: return "m_netp_waitlist_notification_shown"
case .networkProtectionWaitlistNotificationLaunched: return "m_netp_waitlist_notification_launched"

case .networkProtectionGeoswitchingOpened: return "m_netp_imp_geoswitching"
case .networkProtectionGeoswitchingSetNearest: return "m_netp_ev_geoswitching_set_nearest"
case .networkProtectionGeoswitchingSetCustom: return "m_netp_ev_geoswitching_set_custom"
case .networkProtectionGeoswitchingNoLocations: return "m_netp_ev_geoswitching_no_locations"

// MARK: remote messaging pixels

case .remoteMessageShown: return "m_remote_message_shown"
Expand Down
1 change: 1 addition & 0 deletions Core/PrintingUserScript.swift
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ public class PrintingUserScript: NSObject, UserScript {
public var injectionTime: WKUserScriptInjectionTime = .atDocumentStart
public var forMainFrameOnly: Bool = false
public var messageNames: [String] = ["printHandler"]
public var requiresRunInPageContentWorld: Bool = true

public func userContentController(_ userContentController: WKUserContentController, didReceive message: WKScriptMessage) {
delegate?.printingUserScriptDidRequestPrintController(self)
Expand Down
Loading

0 comments on commit d041c90

Please sign in to comment.