Skip to content

Commit

Permalink
Fix maestro config so it runs (#2896)
Browse files Browse the repository at this point in the history
Description:

Maestro e2e tests fail as we apparently cannot filter out tests that are required to run in a specific order.

In addition relying on ddg site for testing is prone to failures when strings change (e.g. due to experiments)
  • Loading branch information
bwaresiak authored May 29, 2024
1 parent 6786dc4 commit c57d4da
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 12 deletions.
10 changes: 9 additions & 1 deletion .github/workflows/sync-end-to-end.yml
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,18 @@ jobs:
- name: Install Maestro
run: |
export MAESTRO_VERSION=1.36.0; curl -Ls "https://get.maestro.mobile.dev" | bash
- name: Overwrite default config with sync one
run: |
cp .maestro/config-sync .maestro/config.yaml
- name: Sync e2e tests
run: |
export PATH="$PATH":"$HOME/.maestro/bin"; maestro cloud --apiKey ${{ secrets.MAESTRO_CLOUD_API_KEY }} --env=CODE=${{ steps.sync-recovery-code.outputs.recovery-code }} --fail-on-timeout=true --timeout=150 --ios-version=${{ matrix.os-version }} --include-tags=sync DerivedData/Build/Products/Debug-iphonesimulator/DuckDuckGo.app .maestro/
- name: Reset config
run: |
git checkout .maestro/config.yaml
notify-failure:
name: Notify on failure
Expand Down
6 changes: 3 additions & 3 deletions .maestro/browser_features/swipe_tabs.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ tags:
id: "searchEntry"
- tapOn:
id: "searchEntry"
- inputText: "https://duckduckgo.com"
- inputText: "https://www.search-company.site"
- pressKey: Enter

# Manage onboarding
Expand All @@ -31,7 +31,7 @@ tags:
index: 0
file: ../shared/onboarding_browsing.yaml

- assertVisible: "Privacy, simplified."
- assertVisible: "Search engine"

# Open New Tab
- tapOn: "Tab Switcher"
Expand All @@ -53,7 +53,7 @@ tags:
start: 10%, 10%
end: 90%, 10%

- assertVisible: "Privacy, simplified."
- assertVisible: "Search engine"

# Ensure address bar still works
- assertVisible:
Expand Down
15 changes: 15 additions & 0 deletions .maestro/config-sync
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
appStartup:
enabled: false
appSize:
enabled: false
flows:
- "**"
executionOrder:
flowsOrder:
- 01_create_account
- 02_login_account
- 03_recover_account
- 04_sync_data_setup
- 05_sync_data_check
- 06_delete_account

8 changes: 0 additions & 8 deletions .maestro/config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,12 +4,4 @@ appSize:
enabled: false
flows:
- "**"
executionOrder:
flowsOrder:
- 01_create_account
- 02_login_account
- 03_recover_account
- 04_sync_data_setup
- 05_sync_data_check
- 06_delete_account

0 comments on commit c57d4da

Please sign in to comment.