correctly fire autoclear pixels

duckduckgo · Dec 12, 2024 · beebf95 · beebf95
1 parent f5c17a6
commit beebf95
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 2 deletions.
diff --git a/DuckDuckGo/AutoClearSettingsViewController.swift b/DuckDuckGo/AutoClearSettingsViewController.swift
@@ -55,7 +55,12 @@ class AutoClearSettingsViewController: UITableViewController {
 
         decorate()
     }
-
+
+    override func viewDidAppear(_ animated: Bool) {
+        super.viewDidAppear(animated)
+        Pixel.fire(pixel: .settingsDataClearingClearDataOpen)
+    }
+
     private func loadClearDataSettings() -> AutoClearSettingsModel? {
         return AutoClearSettingsModel(settings: appSettings)
     }
@@ -152,6 +157,8 @@ class AutoClearSettingsViewController: UITableViewController {
     }
 
     @IBAction func onClearDataToggled(_ sender: UISwitch) {
+        Pixel.fire(pixel: sender.isOn ? .settingsAutomaticallyClearDataOn : .settingsAutomaticallyClearDataOff)
+
         if sender.isOn {
             clearDataSettings = AutoClearSettingsModel()
             tableView.insertSections(.init(integersIn: Sections.action.rawValue...Sections.timing.rawValue), with: .fade)

diff --git a/DuckDuckGo/SettingsViewModel.swift b/DuckDuckGo/SettingsViewModel.swift
@@ -807,7 +807,6 @@ extension SettingsViewModel {
                                                                          queue: .main) { [weak self] _ in
             guard let settings = self?.appSettings else { return }
             self?.state.autoclearDataEnabled = (AutoClearSettingsModel(settings: settings) != nil)
-            Pixel.fire(pixel: self?.state.autoclearDataEnabled == true ? .settingsAutomaticallyClearDataOn : .settingsAutomaticallyClearDataOff)
         }
 
         textZoomObserver = NotificationCenter.default.addObserver(forName: AppUserDefaults.Notifications.textZoomChange,