Update SERP and YT overlay pixel logic

duckduckgo · Oct 30, 2024 · a94c498 · a94c498
1 parent 9433591
commit a94c498
Showing 1 changed file with 13 additions and 11 deletions.
diff --git a/DuckDuckGo/DuckPlayer/DuckPlayer.swift b/DuckDuckGo/DuckPlayer/DuckPlayer.swift
@@ -399,27 +399,29 @@ final class DuckPlayer: DuckPlayerControlling {
             return
         }
 
+        // Based on the URL, determine which pixels to fire
         let isSERP = url.isDuckDuckGoSearch
 
-        var event: Pixel.Event
-        if isSERP  {
+        // Assume we are in the SERP Overlay
+        if isSERP {
             switch userValues.duckPlayerMode {
             case .enabled:
-                event = .duckPlayerSettingsAlwaysOverlaySERP
-            default:
-                event = .duckPlayerSettingsNeverOverlaySERP
+                Pixel.fire(pixel: .duckPlayerSettingsAlwaysOverlaySERP)
+            case .disabled:
+                Pixel.fire(pixel: .duckPlayerSettingsNeverOverlaySERP)
+            default: break
             }
+
+            // Assume we are in the Youtube Overlay
         } else {
             switch userValues.duckPlayerMode {
             case .enabled:
-                event = .duckPlayerSettingsAlwaysOverlayYoutube
-            default:
-                event = .duckPlayerSettingsNeverOverlayYoutube
+                Pixel.fire(pixel: .duckPlayerSettingsAlwaysOverlayYoutube)
+            case .disabled:
+                Pixel.fire(pixel: .duckPlayerSettingsNeverOverlayYoutube)
+            default: break
             }
         }
-
-        Pixel.fire(pixel: event)
-
 
     }