Skip to content

Commit

Permalink
DuckPlayer: Fix YouTube shorts issue (#3392)
Browse files Browse the repository at this point in the history
Task/Issue URL:
https://app.asana.com/0/1204099484721401/1208399924957022/f

**Description**:
- Fixes an issue in where Youtube Shorts UI would break if DuckPlayer is
enabled

<!--
If at any point it isn't actively being worked on/ready for
review/otherwise moving forward strongly consider closing it (or not
opening it in the first place). If you decide not to close it, use Draft
PR while work is still in progress or use `DO NOT MERGE` label to
clarify the PRs state and comment with more information.
-->

**Steps to test this PR**:
1.  Make yourself an internal user
2. Add custom config https://www.jsonblob.com/api/1285150467314016256
3. Set DuckPlayer to 'always'
4. Go to Youtube.com and search for "Metallica Shorts" or directly to:
https://m.youtube.com/results?sp=mAEA&search_query=Metallica+shorts
6. Tap and watch a few "Shorts"; use the back button to return.
7. Watch a "Regular" video from the list below and confirm it launches
in DuckPlayer
  • Loading branch information
afterxleep authored Sep 25, 2024
1 parent 8a8a8df commit 98bdba2
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -10885,7 +10885,7 @@
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 196.0.0;
version = "196.0.0-1";
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,17 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"revision" : "ae3dbec01b8b72dc2ea4c510aecbc802862eab63",
"version" : "196.0.0"
"revision" : "3fd71ae18f438ded6243fe64c7ca23f6acdf2ce9",
"version" : "196.0.0-1"
}
},
{
"identity" : "content-scope-scripts",
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/content-scope-scripts",
"state" : {
"revision" : "9f3717b3913a12956f1386fe7b657f68545fba83",
"version" : "6.15.0"
"revision" : "2bed9e2963b2a9232452911d0773fac8b56416a1",
"version" : "6.17.0"
}
},
{
Expand Down Expand Up @@ -138,7 +138,7 @@
{
"identity" : "swift-argument-parser",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-argument-parser",
"location" : "https://github.com/apple/swift-argument-parser.git",
"state" : {
"revision" : "0fbc8848e389af3bb55c182bc19ca9d5dc2f255b",
"version" : "1.4.0"
Expand Down

0 comments on commit 98bdba2

Please sign in to comment.