Skip to content

Commit

Permalink
bump css + bsk
Browse files Browse the repository at this point in the history
  • Loading branch information
Shane Osbourne committed Nov 18, 2024
1 parent 52b2b79 commit 912cdcd
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 7 deletions.
4 changes: 2 additions & 2 deletions DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -11034,8 +11034,8 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
kind = exactVersion;
version = 210.0.3;
branch = "11-14-css_adding_a_new_messagesecret_properties_for_injected_scripts";
kind = branch;
};
};
9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,17 +32,17 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"revision" : "a296f015a572fdfe53a81de653efb9a6d7fc3eba",
"version" : "210.0.3"
"branch" : "11-14-css_adding_a_new_messagesecret_properties_for_injected_scripts",
"revision" : "e52b8c7c20e2f4c16781f694a3d596dc8df4d201"
}
},
{
"identity" : "content-scope-scripts",
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/content-scope-scripts",
"state" : {
"revision" : "adca39c379b1a124f9990e9d0308c374f32f5018",
"version" : "6.32.0"
"revision" : "f2caf4ff814f4714d07d6fc2cf02498cb54a1389",
"version" : "6.36.0"
}
},
{
Expand Down Expand Up @@ -138,7 +138,7 @@
{
"identity" : "swift-argument-parser",
"kind" : "remoteSourceControl",
"location" : "https://github.com/apple/swift-argument-parser.git",
"location" : "https://github.com/apple/swift-argument-parser",
"state" : {
"revision" : "0fbc8848e389af3bb55c182bc19ca9d5dc2f255b",
"version" : "1.4.0"
Expand Down
1 change: 1 addition & 0 deletions DuckDuckGo/EmailSignupViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,7 @@ extension EmailSignupViewController: SecureVaultManagerDelegate {
func secureVaultManager(_: SecureVaultManager, didRequestRuntimeConfigurationForDomain domain: String, completionHandler: @escaping (String?) -> Void) {
let contentScopeProperties = ContentScopeProperties(gpcEnabled: AppDependencyProvider.shared.appSettings.sendDoNotSell,
sessionKey: "",
messageSecret: "",
featureToggles: ContentScopeFeatureToggles.supportedFeaturesOniOS)

let runtimeConfig = DefaultAutofillSourceProvider.Builder(privacyConfigurationManager: ContentBlocking.shared.privacyConfigurationManager,
Expand Down
3 changes: 3 additions & 0 deletions DuckDuckGo/ScriptSourceProviding.swift
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ protocol ScriptSourceProviding {
var autofillSourceProvider: AutofillUserScriptSourceProvider { get }
var contentScopeProperties: ContentScopeProperties { get }
var sessionKey: String { get }
var messageSecret: String { get }

}

Expand All @@ -45,6 +46,7 @@ struct DefaultScriptSourceProvider: ScriptSourceProviding {
let autofillSourceProvider: AutofillUserScriptSourceProvider
let contentScopeProperties: ContentScopeProperties
let sessionKey: String
let messageSecret: String

let privacyConfigurationManager: PrivacyConfigurationManaging
let contentBlockingManager: ContentBlockerRulesManagerProtocol
Expand All @@ -63,6 +65,7 @@ struct DefaultScriptSourceProvider: ScriptSourceProviding {
surrogatesConfig = Self.buildSurrogatesConfig(contentBlockingManager: contentBlockingManager,
privacyConfigurationManager: privacyConfigurationManager)
sessionKey = Self.generateSessionKey()
messageSecret = Self.generateSessionKey()
contentScopeProperties = ContentScopeProperties(gpcEnabled: appSettings.sendDoNotSell,
sessionKey: sessionKey,

Check failure on line 70 in DuckDuckGo/ScriptSourceProviding.swift

View workflow job for this annotation

GitHub Actions / Unit Tests

missing argument for parameter 'messageSecret' in call

Check failure on line 70 in DuckDuckGo/ScriptSourceProviding.swift

View workflow job for this annotation

GitHub Actions / Make Release Build

missing argument for parameter 'messageSecret' in call

Check failure on line 70 in DuckDuckGo/ScriptSourceProviding.swift

View workflow job for this annotation

GitHub Actions / Make Release Build

missing argument for parameter 'messageSecret' in call
featureToggles: ContentScopeFeatureToggles.supportedFeaturesOniOS)
Expand Down
1 change: 1 addition & 0 deletions DuckDuckGo/TabViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -2976,6 +2976,7 @@ extension TabViewController: SecureVaultManagerDelegate {

return ContentScopeProperties(gpcEnabled: appSettings.sendDoNotSell,
sessionKey: autofillUserScript?.sessionKey ?? "",
messageSecret: autofillUserScript?.messageSecret ?? "",
featureToggles: supportedFeatures)
}

Expand Down

0 comments on commit 912cdcd

Please sign in to comment.