[DuckPlayer] 20. OverlayInteracted (#3234)

**Description**:
- Implement/Fix `overlayInteracted` mode.

<!--

DuckDuckGo/AppUserDefaults.swift

@@ -397,6 +397,8 @@ public class AppUserDefaults: AppSettings {
         }
         set {
             userDefaults?.set(newValue.stringValue, forKey: Keys.duckPlayerMode)
+            // Reset Hidden overlay setting when changing Mode
+            userDefaults?.set(false, forKey: Keys.duckPlayerAskModeOverlayHidden)
             NotificationCenter.default.post(name: AppUserDefaults.Notifications.duckPlayerSettingsUpdated,
                                             object: duckPlayerMode)
         }

DuckDuckGo/DuckPlayer/DuckPlayer.swift

@@ -59,11 +59,6 @@ struct InitialPlayerSettings: Codable {
     let locale: Locale
 }
 
-struct InitialOverlaySettings: Codable {
-    let userValues: UserValues
-}
-
-
 /// Values that the Frontend can use to determine user settings
 public struct UserValues: Codable {
     enum CodingKeys: String, CodingKey {
@@ -148,7 +143,7 @@ final class DuckPlayer: DuckPlayerProtocol {
 
     private func updateSettings(userValues: UserValues) async {
         settings.setMode(userValues.duckPlayerMode)
-        settings.setOverlayHidden(userValues.askModeOverlayHidden)
+        settings.setAskModeOverlayHidden(userValues.askModeOverlayHidden)
     }
 
     public func getUserValues(params: Any, message: WKScriptMessage) -> Encodable? {
@@ -210,13 +205,7 @@ final class DuckPlayer: DuckPlayerProtocol {
         let userValues = encodeUserValues()
         return InitialPlayerSettings(userValues: userValues, settings: playerSettings, platform: platform, locale: locale)
     }
-
-    @MainActor
-    private func encodedOverlaySettings(with webView: WKWebView?) async -> InitialOverlaySettings {
-        let userValues = encodeUserValues()
-        return InitialOverlaySettings(userValues: userValues)
-    }
-
+
     // Accessing WKMessage needs main thread
     @MainActor
     private func firePixels(message: WKScriptMessage, userValues: UserValues) {

DuckDuckGo/DuckPlayer/DuckPlayerSettings.swift

@@ -73,7 +73,7 @@ protocol DuckPlayerSettingsProtocol: AnyObject {
     init(appSettings: AppSettings, privacyConfigManager: PrivacyConfigurationManaging)
 
     func setMode(_ mode: DuckPlayerMode)
-    func setOverlayHidden(_ overlayHidden: Bool)
+    func setAskModeOverlayHidden(_ overlayHidden: Bool)
     func triggerNotification()
 }
 
@@ -125,17 +125,14 @@ final class DuckPlayerSettings: DuckPlayerSettingsProtocol {
         }
     }
 
-    var overlayHidden: Bool {
+    var askModeOverlayHidden: Bool {
         if isFeatureEnabled {
             return appSettings.duckPlayerAskModeOverlayHidden
         } else {
             return false
         }
     }
 
-    @UserDefaultsWrapper(key: .duckPlayerAskModeOverlayHidden, defaultValue: false)
-    var askModeOverlayHidden: Bool
-
     private func registerConfigPublisher() {
         isFeatureEnabledCancellable = privacyConfigManager.updatesPublisher
             .map { [weak privacyConfigManager] in
@@ -161,7 +158,7 @@ final class DuckPlayerSettings: DuckPlayerSettingsProtocol {
         }
     }
 
-    func setOverlayHidden(_ overlayHidden: Bool) {
+    func setAskModeOverlayHidden(_ overlayHidden: Bool) {
         if overlayHidden != appSettings.duckPlayerAskModeOverlayHidden {
             appSettings.duckPlayerAskModeOverlayHidden = overlayHidden
             triggerNotification()

DuckDuckGo/DuckPlayer/YoutubeOverlayUserScript.swift

@@ -166,10 +166,7 @@ extension YoutubeOverlayUserScript {
         case "play.use":
             Pixel.fire(pixel: Pixel.Event.duckPlayerViewFromYoutubeViaMainOverlay, debounce: 2)
             duckPlayerStorage.userInteractedWithDuckPlayer = true
-
-        case "play.use.thumbnail":
-            Pixel.fire(pixel: Pixel.Event.duckPlayerViewFromYoutubeViaHoverButton, debounce: 2)
-
+
         case "play.do_not_use":
             Pixel.fire(pixel: Pixel.Event.duckPlayerOverlayYoutubeWatchHere, debounce: 2)
             duckPlayerStorage.userInteractedWithDuckPlayer = true

DuckDuckGoTests/DuckPlayerMocks.swift

@@ -103,7 +103,7 @@ final class MockDuckPlayerSettings: DuckPlayerSettingsProtocol {
         self.mode = mode
     }
 
-    func setOverlayHidden(_ overlayHidden: Bool) {
+    func setAskModeOverlayHidden(_ overlayHidden: Bool) {
         self.askModeOverlayHidden = overlayHidden
     }