[DuckPlayer] 14. Potential fix to crash (#3161)

Task/Issue URL: https://app.asana.com/0/1204099484721401/1207925784532201/f Description: Properly cancels publisher on deInit
duckduckgo · Jul 31, 2024 · 59a65cd · 59a65cd
1 parent 1671ba0
commit 59a65cd
Showing 1 changed file with 2 additions and 1 deletion.
diff --git a/DuckDuckGo/DuckPlayer/DuckPlayerSettings.swift b/DuckDuckGo/DuckPlayer/DuckPlayerSettings.swift
@@ -177,6 +177,7 @@ final class DuckPlayerSettings: DuckPlayerSettingsProtocol {
     }
 
     deinit {
-        NotificationCenter.default.removeObserver(self)
+        isFeatureEnabledCancellable?.cancel()
+        NotificationCenter.default.removeObserver(self, name: AppUserDefaults.Notifications.duckPlayerSettingsUpdated, object: nil)
     }
 }