Prevent selection animation glitch when editing

duckduckgo · Jan 22, 2024 · 56d9f65 · 56d9f65
1 parent 3ed2865
commit 56d9f65
Show file tree

Hide file tree

Showing 4 changed files with 15 additions and 12 deletions.
diff --git a/DuckDuckGo/AddressDisplayHelper.swift b/DuckDuckGo/AddressDisplayHelper.swift
@@ -23,9 +23,9 @@ extension OmniBar {
 
     struct AddressDisplayHelper {
 
-        static func addressForDisplay(url: URL, isEditing: Bool) -> NSAttributedString {
+        static func addressForDisplay(url: URL, showsFullURL: Bool) -> NSAttributedString {
 
-            if !isEditing, let shortAddress = shortURLString(url) {
+            if !showsFullURL, let shortAddress = shortURLString(url) {
                 return NSAttributedString(
                     string: shortAddress,
                     attributes: [.foregroundColor: ThemeManager.shared.currentTheme.searchBarTextColor])

diff --git a/DuckDuckGo/MainViewController.swift b/DuckDuckGo/MainViewController.swift
@@ -1543,6 +1543,10 @@ extension MainViewController: OmniBarDelegate {
     }
 
     func onTextFieldWillBeginEditing(_ omniBar: OmniBar) {
+        if let currentTab {
+            viewCoordinator.omniBar.refreshText(forUrl: currentTab.url, forceFullURL: true)
+        }
+
         guard homeController == nil else { return }
 
         if !skipSERPFlow, isSERPPresented, let query = omniBar.textField.text {
@@ -1553,8 +1557,7 @@ extension MainViewController: OmniBarDelegate {
     }
 
     func onTextFieldDidBeginEditing(_ omniBar: OmniBar) -> Bool {
-        refreshOmniBar()
-
+
         let selectQueryText = !(isSERPPresented && !skipSERPFlow)
         skipSERPFlow = false
 

diff --git a/DuckDuckGo/OmniBar.swift b/DuckDuckGo/OmniBar.swift
@@ -384,7 +384,7 @@ class OmniBar: UIView {
         omniDelegate?.onOmniQueryUpdated("")
     }
 
-    func refreshText(forUrl url: URL?) {
+    func refreshText(forUrl url: URL?, forceFullURL: Bool = false) {
 
         guard let url = url else {
             textField.text = nil
@@ -394,7 +394,7 @@ class OmniBar: UIView {
         if let query = url.searchQuery {
             textField.text = query
         } else {
-            textField.attributedText = AddressDisplayHelper.addressForDisplay(url: url, isEditing: textField.isEditing)
+            textField.attributedText = AddressDisplayHelper.addressForDisplay(url: url, showsFullURL: textField.isEditing || forceFullURL)
         }
     }
 
@@ -540,7 +540,7 @@ extension OmniBar: Themable {
         searchStackContainer?.tintColor = theme.barTintColor
 
         if let url = textField.text.flatMap({ URL(trimmedAddressBarString: $0.trimmingWhitespace()) }) {
-            textField.attributedText = AddressDisplayHelper.addressForDisplay(url: url, isEditing: textField.isEditing)
+            textField.attributedText = AddressDisplayHelper.addressForDisplay(url: url, showsFullURL: textField.isEditing)
         }
         textField.textColor = theme.searchBarTextColor
         textField.tintColor = UIColor(designSystemColor: .accent)

diff --git a/DuckDuckGoTests/AddressDisplayHelperTests.swift b/DuckDuckGoTests/AddressDisplayHelperTests.swift
@@ -79,20 +79,20 @@ class AddressDisplayHelperTests: XCTestCase {
         XCTAssertNil(AddressHelper.shortURLString(URL(string: "data:text/plain;charset=UTF-8;page=21,the%20data:12345")!))
     }
 
-    func testShortensURLWhenNotEditing() {
-        let addressForDisplay = AddressHelper.addressForDisplay(url: URL(string: "http://some.domain.eu/with/path")!, isEditing: false)
+    func testShortensURLWhenShortVersionExpected() {
+        let addressForDisplay = AddressHelper.addressForDisplay(url: URL(string: "http://some.domain.eu/with/path")!, showsFullURL: false)
 
         XCTAssertEqual(addressForDisplay.string, "some.domain.eu")
     }
 
-    func testDoesNotShortenURLWhenEditing() {
-        let addressForDisplay = AddressHelper.addressForDisplay(url: URL(string: "http://some.domain.eu/with/path")!, isEditing: true)
+    func testDoesNotShortenURLWhenFullVersionExpected() {
+        let addressForDisplay = AddressHelper.addressForDisplay(url: URL(string: "http://some.domain.eu/with/path")!, showsFullURL: true)
 
         XCTAssertEqual(addressForDisplay.string, "http://some.domain.eu/with/path")
     }
 
     func testFallsBackToLongURLWhenCannotProduceShortURL() {
-        let addressForDisplay = AddressHelper.addressForDisplay(url: URL(string: "file:///some/path")!, isEditing: false)
+        let addressForDisplay = AddressHelper.addressForDisplay(url: URL(string: "file:///some/path")!, showsFullURL: false)
 
         XCTAssertEqual(addressForDisplay.string, "file:///some/path")
     }