Skip to content

Commit

Permalink
Use Local navigationType instead
Browse files Browse the repository at this point in the history
  • Loading branch information
afterxleep committed Oct 11, 2024
1 parent 20ea632 commit 5212141
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 1 addition & 1 deletion DuckDuckGo/DuckPlayer/DuckPlayerNavigationHandler.swift
Original file line number Diff line number Diff line change
Expand Up @@ -552,7 +552,7 @@ extension DuckPlayerNavigationHandler: DuckPlayerNavigationHandling {
isFeatureEnabled &&
isSubFeatureEnabled &&
isDuckPlayer &&
navigationAction.navigationType == .linkActivated &&
self.navigationType == .linkActivated &&
isDuckPlayerEnabled {
return true
}
Expand Down
1 change: 1 addition & 0 deletions DuckDuckGoTests/YoutublePlayerNavigationHandlerTests.swift
Original file line number Diff line number Diff line change
Expand Up @@ -493,6 +493,7 @@ class DuckPlayerNavigationHandlerTests: XCTestCase {
let player = MockDuckPlayer(settings: playerSettings, featureFlagger: featureFlagger)
let handler = DuckPlayerNavigationHandler(duckPlayer: player, featureFlagger: featureFlagger, appSettings: mockAppSettings, experiment: DuckPlayerExperimentMock())

handler.navigationType = .linkActivated
playerSettings.mode = .disabled
mockAppSettings.duckPlayerOpenInNewTab = true

Expand Down

0 comments on commit 5212141

Please sign in to comment.