Skip to content

Commit

Permalink
Force Omni Bar cancellation when submitting a query (#2923)
Browse files Browse the repository at this point in the history
Task/Issue URL: https://app.asana.com/0/414709148257752/1207493955850425/f
Tech Design URL:
CC:

Description:

This PR updates the omni bar query submitted callback to cancel the omni bar, to ensure it stays in the correct state.

This bug is caused by MainViewController.onEditingEnd(), which gets checked before the autocomplete controller has been torn down. This puts the omni bar into a suspended state, not dismissed state.
  • Loading branch information
samsymons authored Jun 6, 2024
1 parent 2aad47f commit 272119b
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions DuckDuckGo/MainViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -1714,6 +1714,7 @@ extension MainViewController: OmniBarDelegate {
if !DaxDialogs.shared.shouldShowFireButtonPulse {
ViewHighlighter.hideAll()
}
omniBar.cancel()
loadQuery(query)
hideSuggestionTray()
hideNotificationBarIfBrokenSitePromptShown()
Expand Down

0 comments on commit 272119b

Please sign in to comment.