Skip to content

Commit

Permalink
Not firing reportBrokenSiteShown automatically
Browse files Browse the repository at this point in the history
  • Loading branch information
jaceklyp authored and mgurgel committed Jan 17, 2025
1 parent 44da2a4 commit 233d7b0
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 16 deletions.
2 changes: 1 addition & 1 deletion DuckDuckGo.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -11924,7 +11924,7 @@
isa = XCRemoteSwiftPackageReference;
repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
requirement = {
branch = "mgurgel/improved-breakage-form";
branch = "mgurgel/improved-breakage-form-pixel";
kind = branch;
};
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
"state" : {
"branch" : "mgurgel/improved-breakage-form",
"revision" : "c77e36efe790bc01af9b152fc0ef0fbb35a32f82"
"branch" : "mgurgel/improved-breakage-form-pixel",
"revision" : "89cdcdc2e18e8a4df5ee69c48b1b2ace828ae929"
}
},
{
Expand Down Expand Up @@ -122,8 +122,8 @@
"kind" : "remoteSourceControl",
"location" : "https://github.com/duckduckgo/privacy-dashboard",
"state" : {
"revision" : "3f58e008d4e9d1b56ab12dbb95bd891045cf2758",
"version" : "8.0.0"
"branch" : "pr-releases/pr-302",
"revision" : "05d04de7505117b32949b2007e5a56ba2d39469b"
}
},
{
Expand Down
11 changes: 0 additions & 11 deletions DuckDuckGo/MainViewController+Segues.swift
Original file line number Diff line number Diff line change
Expand Up @@ -108,10 +108,6 @@ extension MainViewController {
return
}

if entryPoint == .report {
fireBrokenSiteReportShown()
}

let storyboard = UIStoryboard(name: "PrivacyDashboard", bundle: nil)
let controller = storyboard.instantiateInitialViewController { coder in
PrivacyDashboardViewController(coder: coder,
Expand Down Expand Up @@ -141,13 +137,6 @@ extension MainViewController {
present(controller, animated: true)
}

private func fireBrokenSiteReportShown() {
let parameters = [
PrivacyDashboardEvents.Parameters.source: BrokenSiteReport.Source.appMenu.rawValue
]
Pixel.fire(pixel: .reportBrokenSiteShown, withAdditionalParameters: parameters)
}

func segueToNegativeFeedbackForm() {
Logger.lifecycle.debug(#function)
hideAllHighlightsIfNeeded()
Expand Down

0 comments on commit 233d7b0

Please sign in to comment.