Improved approach to handle maestro crash

duckduckgo · Oct 3, 2024 · 1f3da19 · 1f3da19
1 parent e0c6a10
commit 1f3da19
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 8 deletions.
diff --git a/.maestro/release_tests/password-management.yaml b/.maestro/release_tests/password-management.yaml
@@ -49,14 +49,6 @@ tags:
 
 - tapOn: "Save"
 - tapOn: "Passwords"
-
-# Dismiss Sync Promo if visible
-- runFlow:
-    when:
-        visible: "No Thanks"
-    commands:
-        - tapOn: "No Thanks"
-
 - tapOn: "Settings"
 - tapOn: "Done"
 

diff --git a/DuckDuckGo/SyncPromoView.swift b/DuckDuckGo/SyncPromoView.swift
@@ -24,13 +24,16 @@ import DuckUI
 struct SyncPromoView: View {
 
     let viewModel: SyncPromoViewModel
+    @State private var isAccessibilityHidden = true
 
     var body: some View {
         ZStack(alignment: .topTrailing) {
             VStack(spacing: 8) {
                 Group {
                     Image(viewModel.image)
                         .scaledToFit()
+                        .accessibilityHidden(true)
+
                     Text(viewModel.title)
                         .padding(.top, 4)
                         .frame(maxWidth: .infinity)
@@ -83,13 +86,21 @@ struct SyncPromoView: View {
             .alignmentGuide(.top) { dimension in
                 dimension[.top]
             }
+            .accessibilityHidden(true)
         }
         .background(
             RoundedRectangle(cornerRadius: 8)
                 .foregroundColor(Color(designSystemColor: .surface))
         )
         .padding(.horizontal, 20)
         .padding(.bottom, 12)
+        .accessibilityHidden(isAccessibilityHidden)
+        .onAppear {
+            // Delay accessibility activation for maestro
+            DispatchQueue.main.asyncAfter(deadline: .now() + 1.0) {
+                isAccessibilityHidden = false
+            }
+        }
     }
 }