Remove VPN test rollout pixel (#3536)

Task/Issue URL: https://app.asana.com/0/1205278999335242/1208159133216403/f Tech Design URL: CC: Description: This PR removes the test rollout pixel for the remote config.
duckduckgo · Nov 6, 2024 · 1f334a5 · 1f334a5
1 parent 3aad126
commit 1f334a5
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 13 deletions.
diff --git a/Core/PixelEvent.swift b/Core/PixelEvent.swift
@@ -466,7 +466,6 @@ extension Pixel {
         case networkProtectionVPNConfigurationRemovalFailed
 
         case networkProtectionConfigurationInvalidPayload(configuration: Configuration)
-        case networkProtectionConfigurationPixelTest
 
         case networkProtectionMalformedErrorDetected
 
@@ -1279,7 +1278,6 @@ extension Pixel.Event {
         case .networkProtectionVPNConfigurationRemovalFailed: return "m_netp_vpn_configuration_removal_failed"
 
         case .networkProtectionConfigurationInvalidPayload(let config): return "m_netp_vpn_configuration_\(config.rawValue)_invalid_payload"
-        case .networkProtectionConfigurationPixelTest: return "m_netp_vpn_configuration_pixel_test"
 
         case .networkProtectionMalformedErrorDetected: return "m_netp_vpn_malformed_error_detected"
 

diff --git a/DuckDuckGo.xcodeproj/project.pbxproj b/DuckDuckGo.xcodeproj/project.pbxproj
@@ -10986,7 +10986,7 @@
 			repositoryURL = "https://github.com/DuckDuckGo/BrowserServicesKit";
 			requirement = {
 				kind = exactVersion;
-				version = 205.0.0;
+				version = 206.0.0;
 			};
 		};
 		9F8FE9472BAE50E50071E372 /* XCRemoteSwiftPackageReference "lottie-spm" */ = {

diff --git a/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved b/DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
@@ -32,8 +32,8 @@
       "kind" : "remoteSourceControl",
       "location" : "https://github.com/DuckDuckGo/BrowserServicesKit",
       "state" : {
-        "revision" : "1d228b8fde43e7ab5f28e7a511f440676e6b05a8",
-        "version" : "205.0.0"
+        "revision" : "d00f87a30e35fe8f86df30973c3b5370688e3aaa",
+        "version" : "206.0.0"
       }
     },
     {

diff --git a/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift b/PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift
@@ -41,7 +41,6 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider {
 
     private let configurationStore = ConfigurationStore()
     private let configurationManager: ConfigurationManager
-    private var configuationSubscription: AnyCancellable?
 
     // MARK: - PacketTunnelProvider.Event reporting
 
@@ -407,13 +406,6 @@ final class NetworkProtectionPacketTunnelProvider: PacketTunnelProvider {
         // Load cached config (if any)
         privacyConfigurationManager.reload(etag: configurationStore.loadEtag(for: .privacyConfiguration), data: configurationStore.loadData(for: .privacyConfiguration))
 
-        configuationSubscription = privacyConfigurationManager.updatesPublisher
-            .sink {
-                if privacyConfigurationManager.privacyConfig.isSubfeatureEnabled(BackgroundAgentPixelTestSubfeature.pixelTest) {
-                    DailyPixel.fire(pixel: .networkProtectionConfigurationPixelTest)
-                }
-            }
-
         // Align Subscription environment to the VPN environment
         var subscriptionEnvironment = SubscriptionEnvironment.default
         switch settings.selectedEnvironment {