move ending refresh to when we hide the progress indiciator

duckduckgo · Jan 17, 2024 · 06f8b42 · 06f8b42
1 parent c3112f7
commit 06f8b42
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/DuckDuckGo/TabViewController.swift b/DuckDuckGo/TabViewController.swift
@@ -418,7 +418,6 @@ class TabViewController: UIViewController {
         webView.scrollView.refreshControl = UIRefreshControl()
         webView.scrollView.refreshControl?.addAction(UIAction { [weak self] _ in
             self?.reload()
-            self?.webView.scrollView.refreshControl?.endRefreshing()
         }, for: .valueChanged)
 
         webView.scrollView.refreshControl?.backgroundColor = .systemBackground
@@ -654,6 +653,7 @@ class TabViewController: UIViewController {
 
     private func hideProgressIndicator() {
         progressWorker.didFinishLoading()
+        webView.scrollView.refreshControl?.endRefreshing()
     }
 
     public func reload() {
@@ -1181,10 +1181,7 @@ extension TabViewController: WKNavigationDelegate {
     }
 
     private func onWebpageDidFinishLoading() {
-        os_log("webpageLoading finished", log: .generalLog, type: .debug)
-
-        Swift.print("***", #function, webView.scrollView.contentOffset, webView.scrollView.contentInset)
-
+        os_log("webpageLoading finished", log: .generalLog, type: .debug)                
         tabModel.link = link
         delegate?.tabLoadingStateDidChange(tab: self)