Skip to content

Commit

Permalink
remove address bar position pixels (#2220)
Browse files Browse the repository at this point in the history
  • Loading branch information
brindy authored Dec 5, 2023
1 parent f822b76 commit 000aa58
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 14 deletions.
6 changes: 0 additions & 6 deletions Core/PixelEvent.swift
Original file line number Diff line number Diff line change
Expand Up @@ -262,9 +262,6 @@ extension Pixel {

case autofillJSPixelFired(_ pixel: AutofillUserScript.JSPixel)

case navigationbarPositionBottom
case navigationBarPositionTop

case secureVaultInitError
case secureVaultError

Expand Down Expand Up @@ -625,9 +622,6 @@ extension Pixel.Event {
case .autocompleteSelectedLocal: return "m_au_l"
case .autocompleteSelectedRemote: return "m_au_r"

case .navigationbarPositionBottom: return "m_seturlbar_bottom"
case .navigationBarPositionTop: return "m_seturlbar_top"

case .feedbackPositive: return "mfbs_positive_submit"
case .feedbackNegativePrefix(category: let category): return "mfbs_negative_\(category)"

Expand Down
8 changes: 0 additions & 8 deletions DuckDuckGo/AddressBarPositionSettingsViewController.swift
Original file line number Diff line number Diff line change
Expand Up @@ -53,14 +53,6 @@ class AddressBarPositionSettingsViewController: UITableViewController {

override func tableView(_ tableView: UITableView, didSelectRowAt indexPath: IndexPath) {
appSettings.currentAddressBarPosition = AddressBarPosition.allCases[indexPath.row]

switch appSettings.currentAddressBarPosition {
case .top:
Pixel.fire(pixel: .navigationBarPositionTop)
case .bottom:
Pixel.fire(pixel: .navigationbarPositionBottom)
}

tableView.performBatchUpdates {
tableView.reloadSections(IndexSet(integer: 0), with: .automatic)
tableView.deselectRow(at: indexPath, animated: true)
Expand Down

0 comments on commit 000aa58

Please sign in to comment.