Skip to content

Refactor AppDelegate (milestone 1) #9781

Refactor AppDelegate (milestone 1)

Refactor AppDelegate (milestone 1) #9781

Triggered via pull request December 16, 2024 14:41
Status Failure
Total duration 14m 13s
Artifacts

pr.yml

on: pull_request
Create Asana Task
0s
Create Asana Task
Close Asana Task
0s
Close Asana Task
Fit to window
Zoom out
Zoom in

Annotations

2 errors, 24 warnings, and 10 notices
SwiftLint: DuckDuckGo/AppDelegate.swift#L30
Delegate protocols should be class-only so they can be weakly referenced (class_delegate_protocol)
SwiftLint: DuckDuckGo/OldAppDelegate.swift#L1
Header comments should be consistent with project patterns (file_header)
ShellCheck
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
SwiftLint
ubuntu-latest pipelines will use ubuntu-24.04 soon. For more details, see https://github.com/actions/runner-images/issues/10636
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L102
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L148
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L178
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
Make Release Build: DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Make Release Build: Core/Pixel.swift#L275
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build: Core/StatisticsLoader.swift#L80
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
Make Release Build
xcbeautify 2.16.0 is already installed and up-to-date. To reinstall 2.16.0, run: brew reinstall xcbeautify
Unit Tests
xcbeautify 2.16.0 is already installed and up-to-date. To reinstall 2.16.0, run: brew reinstall xcbeautify
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests: DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenCallActionOnOnboardingFinalDialog_ThenDidTapDismissContextualOnboardingActionOnDelegateIsCalled
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewFire_ThenReturnViewOnboardingFireDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasNotShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForAfterSearchSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenDidTapDismissContextualOnboardingActionIsCalledOnDelegate
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForFinalSpec_ThenReturnViewOnboardingFinalDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasNotShown_ThenActionCallsDidAcknowledgeContextualOnboardingTrackersDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_AndFireDialogHasShown_ThenActionCallsDidTapDismissContextualOnboardingAction
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForTrackerSpec_ThenReturnViewOnboardingTrackersDoneDialog
Unit Tests
Skipped UnitTests.ContextualDaxDialogsFactoryTests.test_WhenMakeViewForVisitWebsiteSpec_AndActionIsTapped_AndTrackersDialogHasShown_ThenNavigateToActionIsCalledOnDelegate