Malicious site protection - extract special error page navigation logic #9370
alessandroboronpr.yml
on: pull_request
SwiftLint
39s
ShellCheck
8s
Unit Tests
9m 14s
Make Release Build
7m 5s
Annotations
4 errors, 22 warnings, and 4 notices
|
SwiftLint:
DuckDuckGoTests/SpecialErrorPage/TestDoubles/MockSSLErrorPageNavigationHandler.swift#L44
Tuples should have at most 2 members (large_tuple)
|
|
SwiftLint:
DuckDuckGoTests/SpecialErrorPage/TestDoubles/DummyWKNavigation.swift#L1
Header comments should be consistent with project patterns (file_header)
|
|
SwiftLint:
DuckDuckGo/SpecialErrorPage/SpecialErrorPageNavigationHandler+SSL.swift#L29
Tuples should have at most 2 members (large_tuple)
|
|
SwiftLint:
DuckDuckGo/SpecialErrorPage/SpecialErrorPageNavigationHandler+SSL.swift#L66
Tuples should have at most 2 members (large_tuple)
|
|
Make Release Build:
DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Make Release Build:
Core/Pixel.swift#L271
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L91
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L121
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L150
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
|
|
Make Release Build:
DerivedData/Build/Products/Release-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Make Release Build:
Core/Pixel.swift#L271
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build:
Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Make Release Build
xcbeautify 2.15.0 is already installed and up-to-date.
To reinstall 2.15.0, run:
brew reinstall xcbeautify
|
|
Unit Tests
xcbeautify 2.15.0 is already installed and up-to-date.
To reinstall 2.15.0, run:
brew reinstall xcbeautify
|
|
Unit Tests:
DerivedData/Build/Products/Debug-iphonesimulator/PackageFrameworks/GRDB.framework/Headers/GRDB.h#L11
umbrella header for module 'GRDB' does not include header 'sqlite3.h'
|
|
Unit Tests:
Core/StatisticsLoader.swift#L69
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/StatisticsLoader.swift#L91
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/StatisticsLoader.swift#L121
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/StatisticsLoader.swift#L150
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/Pixel.swift#L271
'fetch(completion:)' is deprecated: Please use 'APIService' instead.
|
|
Unit Tests:
Core/SyncBookmarksAdapter.swift#L199
'taskID' mutated after capture by sendable closure
|
|
Unit Tests
Accent color ‘AccentColor’ is not present in any asset catalogs.
|
|
Unit Tests
Background color ‘WidgetBackground’ is not present in any asset catalogs.
|
|
Unit Tests:
DuckDuckGo/FavoritesDisplayMode+UserDefaults.swift#L23
extension declares a conformance of imported type 'FavoritesDisplayMode' to imported protocol 'LosslessStringConvertible'; this will not behave correctly if the owners of 'Bookmarks' introduce this conformance in the future
|
|
Unit Tests
Skipped UnitTests.AutofillLoginListViewModelTests.testWhenBreakageReporterConfigEnabledAndReportAlreadyRecentlySavedThenShowBreakageReporterIsFalse
|
|
Unit Tests
Skipped UnitTests.UsageSegmentationCalculationTests.testPerformance
|
|
Unit Tests
Skipped UnitTests.WebCacheManagerTests.testWhenClearedWithDataStoreContainerThenDDGCookiesAreRetained
|
|
Unit Tests
Test run with 17 tests passed after 0.259 seconds
|