-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DuckPlayer] Add feature flag and update C.S.S #983
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 10, 2024
Bunn
reviewed
Sep 11, 2024
.swiftpm/xcode/xcshareddata/xcschemes/BrowserServicesKit-Package.xcscheme
Outdated
Show resolved
Hide resolved
Bunn
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Comment about the PhishingDetectionTest changes in the xcscheme
afterxleep
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Sep 12, 2024
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208271424696738/f BSK PR: duckduckgo/BrowserServicesKit#983 **Description**: - BSK Update
afterxleep
added a commit
to duckduckgo/iOS
that referenced
this pull request
Sep 12, 2024
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208271424696738/f BSK PR: duckduckgo/BrowserServicesKit#983 **Description**: - Updates C.S.S - Adds subfeature flag
samsymons
added a commit
that referenced
this pull request
Sep 13, 2024
* main: Revert "C.S.S Patch Privacy Config on C.S.S for "internal" support in… (#995) C.S.S Patch Privacy Config on C.S.S for "internal" support in DuckPlayer (#994) return urls on burn domains (#992) Update survey builder OS version (#984) Add feature flag for SKAN API (#993) [DuckPlayer] Add feature flag and update C.S.S (#983) Update Onboarding gradients (#985) Fix WKDownload cancellation under Xcode 16 (#986) Add shouldCheckServerTrust flag (#982) Promote password import in autofill menu (#976) Add Phishing Detection Feature (#981) Revert "Add Phishing Detection Package" (#980) Add Phishing Detection Package (#935) Update VPN user agent (#971) New feature flag for autofillSurveys (#974)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/1204099484721401/1208271424696738/f
What kind of version bump will this require?: Minor
macOS PR: duckduckgo/macos-browser#3244
iOS PR: duckduckgo/iOS#3346
Description:
Steps to test this PR: