Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DuckPlayer] Add feature flag and update C.S.S #983

Merged
merged 5 commits into from
Sep 12, 2024
Merged

Conversation

afterxleep
Copy link
Collaborator

@afterxleep afterxleep commented Sep 10, 2024

Please review the release process for BrowserServicesKit here.

Required:

Task/Issue URL: https://app.asana.com/0/1204099484721401/1208271424696738/f
What kind of version bump will this require?: Minor

macOS PR: duckduckgo/macos-browser#3244
iOS PR: duckduckgo/iOS#3346

Description:

  • Adds DuckPlayer rollout subfeature
  • Bumps C.S.S to the latest version

Steps to test this PR:

  • See platform PR's

Copy link
Contributor

@Bunn Bunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Comment about the PhishingDetectionTest changes in the xcscheme

@afterxleep afterxleep merged commit b55c174 into main Sep 12, 2024
7 checks passed
@afterxleep afterxleep deleted the daniel/css.bump branch September 12, 2024 08:08
afterxleep added a commit to duckduckgo/macos-browser that referenced this pull request Sep 12, 2024
afterxleep added a commit to duckduckgo/iOS that referenced this pull request Sep 12, 2024
Task/Issue URL:
https://app.asana.com/0/1204099484721401/1208271424696738/f

BSK PR: duckduckgo/BrowserServicesKit#983

**Description**:
- Updates C.S.S
- Adds subfeature flag
samsymons added a commit that referenced this pull request Sep 13, 2024
* main:
  Revert "C.S.S Patch Privacy Config on C.S.S for "internal" support in… (#995)
  C.S.S Patch Privacy Config on C.S.S for "internal" support in DuckPlayer  (#994)
  return urls on burn domains (#992)
  Update survey builder OS version (#984)
  Add feature flag for SKAN API (#993)
  [DuckPlayer] Add feature flag and update C.S.S (#983)
  Update Onboarding gradients (#985)
  Fix WKDownload cancellation under Xcode 16 (#986)
  Add shouldCheckServerTrust flag (#982)
  Promote password import in autofill menu (#976)
  Add Phishing Detection Feature (#981)
  Revert "Add Phishing Detection Package" (#980)
  Add Phishing Detection Package (#935)
  Update VPN user agent (#971)
  New feature flag for autofillSurveys (#974)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants