Remove WireGuard from BSK #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It will now be added as a dependency of the extensions that use it, to avoid embedding it in all other clients that only need surface-level NetworkProtection functionality.
* main: Switch PR Checks to macos-14 free runner (#959)
quanganhdo
approved these changes
Aug 27, 2024
* main: Unified feedback form for Privacy Pro (#922) bump privacy-dashboard to 5.1.1 (#955) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `afb4f61` to `6133e7d` (#962) Freemium PIR - Add Desktop RMF Attribute (#960) Fix address bar queries when doing math expressions (#952)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review the release process for BrowserServicesKit here.
Required:
Task/Issue URL: https://app.asana.com/0/414709148257752/1207874749913488/f
iOS PR: duckduckgo/iOS#3273
macOS PR: duckduckgo/macos-browser#3144
What kind of version bump will this require?: Major
Description:
This PR removes
wireguard-appleas a direct dependency of BSK, and shifts that dependency to the clients.Steps to test this PR:
OS Testing:
Internal references:
Software Engineering Expectations
Technical Design Template