Fix address bar queries when doing math expressions #952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 21, 2024
jotaemepereira
requested review from
a team and
alessandroboron
and removed request for
a team
jotaemepereira
force-pushed
the
juan/fix-address-bar-calculations
branch
2 times, most recently
from
a486a77 to
680f8fc
Compare
| } | ||
| } | ||
|
|
||
| func testWhenStringIsInvalidHost_thenValidHostIsFalse() { |
jotaemepereira
force-pushed
the
juan/fix-address-bar-calculations
branch
from
46e64e1 to
21a0eb4
Compare
jotaemepereira
added a commit
to duckduckgo/iOS
that referenced
this pull request
Aug 26, 2024
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208002970105121/f BSK PR: duckduckgo/BrowserServicesKit#952 **Description**: This pull request introduces a change on how we check for valid hostnames. The current regurlar expression had an issue where some mathematical expressions where valid hostnames. Also, following the philosophy about leaving the code a bit better when you touched it. I’ve added tests for the query submitted flow on the `OmniBar`. This PR fixes **Steps to test this PR**: 1. Open the app 2. Put `16385-12228.75` in the address bar 3. This should do a search on our SERP instead of trying to open a webpage 4. Test other usual web sites URLs and check those are working. **Definition of Done (Internal Only)**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
jotaemepereira
added a commit
to duckduckgo/macos-browser
that referenced
this pull request
Aug 26, 2024
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208002970105121/f Tech Design URL: CC: **Description**: This pull request introduces a change on how we check for valid hostnames. The current regurlar expression had an issue where some mathematical expressions where valid hostnames. BSK PR: duckduckgo/BrowserServicesKit#952 **Steps to test this PR**: 1. Open the app 2. Put 16385-12228.75 in the address bar 3. This should do a search on our SERP instead of trying to open a webpage 4. Test other usual web sites URLs and check those are working. **Definition of Done**: * [x] Does this PR satisfy our [Definition of Done](https://app.asana.com/0/1202500774821704/1207634633537039/f)?
samsymons
added a commit
that referenced
this pull request
Aug 28, 2024
* main: Unified feedback form for Privacy Pro (#922) bump privacy-dashboard to 5.1.1 (#955) Bump Tests/BrowserServicesKitTests/Resources/privacy-reference-tests from `afb4f61` to `6133e7d` (#962) Freemium PIR - Add Desktop RMF Attribute (#960) Fix address bar queries when doing math expressions (#952)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1204006570077678/1208002970105121/f
iOS PR: duckduckgo/iOS#3262
macOS PR: duckduckgo/macos-browser#3130
What kind of version bump will this require?: Minor
Description:
This pull request introduces a change on how we check for valid hostnames. The current regurlar expression had an issue where some mathematical expressions where valid hostnames.
Steps to test this PR:
Follow the tests provided for each platform pull request.
Internal references:
Software Engineering Expectations
Technical Design Template